Skip to content

♻️ Updates role inheritance for Admin role #8186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 5, 2025
Merged

♻️ Updates role inheritance for Admin role #8186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2d39dd3
Updates role inheritance for improved permission structure
matusdrobuliak66 Aug 4, 2025
f532767
modify test:
matusdrobuliak66 Aug 4, 2025
aba79d8
Merge branch 'master' into make-admin-have-access-to-po-center
matusdrobuliak66 Aug 4, 2025
7fc643f
modify test
matusdrobuliak66 Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion services/web/server/src/simcore_service_webserver/security/_authz_access_roles.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ class PermissionDict(TypedDict, total=False):
"resource-usage.write",
"storage.files.sync",
],
inherits=[UserRole.TESTER],
inherits=[UserRole.PRODUCT_OWNER],
),
}

Expand Down
2 changes: 1 addition & 1 deletion services/web/server/tests/unit/with_dbs/03/invitations/test_products_rest_invitations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
(UserRole.USER, status.HTTP_403_FORBIDDEN),
(UserRole.TESTER, status.HTTP_403_FORBIDDEN),
(UserRole.PRODUCT_OWNER, status.HTTP_200_OK),
(UserRole.ADMIN, status.HTTP_403_FORBIDDEN),
(UserRole.ADMIN, status.HTTP_200_OK),
],
)
async def test_role_access_to_generate_invitation(
Expand Down
3 changes: 2 additions & 1 deletion ...es/web/server/tests/unit/with_dbs/03/invitations/test_users_accounts_rest_registration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,10 @@ async def mock_send_message(msg):
*(
(role, status.HTTP_403_FORBIDDEN)
for role in UserRole
if role not in {UserRole.PRODUCT_OWNER, UserRole.ANONYMOUS}
if role not in {UserRole.PRODUCT_OWNER, UserRole.ADMIN, UserRole.ANONYMOUS}
),
(UserRole.PRODUCT_OWNER, status.HTTP_200_OK),
(UserRole.ADMIN, status.HTTP_200_OK),
],
)
async def test_access_rights_on_search_users_only_product_owners_can_access(
Expand Down
2 changes: 1 addition & 1 deletion services/web/server/tests/unit/with_dbs/04/products/test_products_rest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ async def test_get_product_price_when_undefined(
(UserRole.USER, status.HTTP_403_FORBIDDEN),
(UserRole.TESTER, status.HTTP_403_FORBIDDEN),
(UserRole.PRODUCT_OWNER, status.HTTP_200_OK),
(UserRole.ADMIN, status.HTTP_403_FORBIDDEN),
(UserRole.ADMIN, status.HTTP_200_OK),
],
)
async def test_get_product_access_rights(
Expand Down
Loading