Skip to content

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Aug 6, 2025

What do these changes do?

None.copy() does not exist if the annotation field is empty. Using deepcopy which can deal with such edge cases

Related issue/s

How to test

Dev-ops

@GitHK GitHK self-assigned this Aug 6, 2025
@GitHK GitHK marked this pull request as ready for review August 6, 2025 08:54
@GitHK GitHK added bug buggy, it does not work as expected a:webserver webserver's codebase. Assigning the area is particularly useful for bugs labels Aug 6, 2025
@GitHK GitHK added this to the Voyager milestone Aug 6, 2025
@codecov
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.33%. Comparing base (227bde0) to head (f8f6011).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8193      +/-   ##
==========================================
- Coverage   88.03%   85.33%   -2.71%     
==========================================
  Files        1907      738    -1169     
  Lines       73282    33770   -39512     
  Branches     1302      176    -1126     
==========================================
- Hits        64514    28816   -35698     
+ Misses       8380     4896    -3484     
+ Partials      388       58     -330     
Flag Coverage Δ
integrationtests 64.36% <0.00%> (+0.05%) ⬆️
unittests 87.38% <100.00%> (+0.70%) ⬆️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 76.98% <ø> (-8.13%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 77.98% <ø> (-12.88%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 87.23% <ø> (-2.89%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 88.16% <100.00%> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 227bde0...f8f6011. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GitHK GitHK requested a review from matusdrobuliak66 August 6, 2025 10:17
@GitHK GitHK added 🤖-automerge marks PR as ready to be merged for Mergify and removed 🤖-automerge marks PR as ready to be merged for Mergify labels Aug 6, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 6, 2025

Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mrnicegyu11 mrnicegyu11 merged commit d7156fb into ITISFoundation:master Aug 6, 2025
92 of 95 checks passed
@mrnicegyu11
Copy link
Member

Force merged at @GitHK request

@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 8, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:webserver webserver's codebase. Assigning the area is particularly useful for bugs bug buggy, it does not work as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants