Skip to content

🐛 [Frontend] Fix: change context search #8194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 6, 2025
Merged

🐛 [Frontend] Fix: change context search #8194

merged 6 commits into from
Aug 6, 2025

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Aug 6, 2025 •
edited
Loading

What do these changes do?

SearchAndChangeContext

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz self-assigned this Aug 6, 2025
@odeimaiz odeimaiz added this to the Voyager milestone Aug 6, 2025
@odeimaiz odeimaiz added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Aug 6, 2025
@odeimaiz odeimaiz requested a review from Copilot August 6, 2025 09:17
Copilot AI reviewed Aug 6, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue with search context handling in the study browser. The fix replaces a switch statement with an array includes check and adds a condition to prevent unnecessary context changes when both the search context and search text remain unchanged.

  • Replace switch statement with array includes check for better search context handling
  • Add condition to check both context and search text when determining whether to proceed with context change

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@odeimaiz odeimaiz marked this pull request as ready for review August 6, 2025 09:19
@odeimaiz odeimaiz requested review from GitHK, giancarloromeo, matusdrobuliak66 and sanderegg and removed request for sanderegg August 6, 2025 09:20
@odeimaiz
Copy link
Member Author

odeimaiz commented Aug 6, 2025

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Aug 6, 2025 •
edited
Loading

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • label=🤖-automerge
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
      • any of: [🛡 GitHub branch protection]
        • check-success = SonarCloud Code Analysis
        • check-neutral = SonarCloud Code Analysis
        • check-skipped = SonarCloud Code Analysis
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

giancarloromeo
giancarloromeo approved these changes Aug 6, 2025
View reviewed changes
Copy link
Contributor

@giancarloromeo giancarloromeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@odeimaiz odeimaiz merged commit 227bde0 into ITISFoundation:master Aug 6, 2025
108 of 110 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 8, 2025
Closed
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@GitHK GitHK Awaiting requested review from GitHK

Assignees

@odeimaiz odeimaiz

Labels

a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected

Projects

None yet

Milestone

Voyager

Development

Successfully merging this pull request may close these issues.

Search Filter: Search when context changes

3 participants

@odeimaiz @giancarloromeo @matusdrobuliak66