🐛 [Frontend] Enh: Include version number in 3r party jsondiffpatch file #8195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the JsonDiffPatch library reference to include a specific version number (0.7.3) in the filename and manifest configuration.
- Updates the JsonDiffPatch library path to include version 0.7.3 in the filename
- Ensures consistent naming between the JavaScript wrapper and manifest configuration
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| JsonDiffPatch.js | Updates the library path to include version number 0.7.3 |
| Manifest.json | Updates the external library reference to match the versioned filename |
Comments suppressed due to low confidence (1)
services/static-webserver/client/Manifest.json:30
- The filename format is inconsistent between the two files. In JsonDiffPatch.js it's 'jsondiffpatch-0.7.3.min.js' (with hyphen) but in Manifest.json it's 'jsondiffpatch.0.7.3.min.js' (with dot). These should match for consistency.
"jsondiffpatch/jsondiffpatch.0.7.3.min.js",
Member
Author
|
@mergify queue |
Contributor
🟠 Waiting for conditions to match
|
matusdrobuliak66
approved these changes
Aug 6, 2025
giancarloromeo
approved these changes
Aug 6, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR simply renames the file jsondiffpatch.min.js to include its version number. In a previous PR this library was upgraded without changing its filename. This can make browsers not fetch the just upgraded library and use the one they have in the cache.
Since from some time now, users do not need to hard reload the app to get the latest version, this cached library could bring unexpected scenarios.
Related issue/s
How to test
Dev-ops