Skip to content

Conversation

@giancarloromeo
Copy link
Contributor

What do these changes do?

Related issue/s

How to test

Dev-ops

@giancarloromeo giancarloromeo added this to the Voyager milestone Aug 6, 2025
@giancarloromeo giancarloromeo self-assigned this Aug 6, 2025
@giancarloromeo giancarloromeo added bug buggy, it does not work as expected a:celery-library labels Aug 6, 2025
@codecov
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.04%. Comparing base (8a62bd4) to head (2422797).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8197      +/-   ##
==========================================
- Coverage   88.09%   88.04%   -0.05%     
==========================================
  Files        1910     1440     -470     
  Lines       73492    59053   -14439     
  Branches     1301      678     -623     
==========================================
- Hits        64743    51995   -12748     
+ Misses       8362     6820    -1542     
+ Partials      387      238     -149     
Flag Coverage Δ
integrationtests 64.24% <ø> (+0.01%) ⬆️
unittests 86.33% <100.00%> (-0.39%) ⬇️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library 85.27% <100.00%> (-2.10%) ⬇️
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 71.62% <ø> (-0.03%) ⬇️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.10% <ø> (+0.05%) ⬆️
agent 93.81% <ø> (ø)
api_server 93.26% <ø> (ø)
autoscaling 95.89% <ø> (ø)
catalog 92.34% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 92.37% <ø> (ø)
datcore_adapter 97.94% <ø> (ø)
director 76.14% <ø> (-0.10%) ⬇️
director_v2 91.02% <ø> (+0.08%) ⬆️
dynamic_scheduler 96.27% <ø> (ø)
dynamic_sidecar 90.12% <ø> (ø)
efs_guardian 89.60% <ø> (ø)
invitations 91.44% <ø> (ø)
payments 92.60% <ø> (ø)
resource_usage_tracker 92.18% <ø> (+0.10%) ⬆️
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 88.27% <ø> (-0.04%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a62bd4...2422797. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

from ...models import FileMetaData


def setup_task_manager(app: FastAPI, celery_settings: CelerySettings) -> None:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to migrate storage to new FastAPI's lifespans...

@mergify
Copy link
Contributor

mergify bot commented Aug 15, 2025

🧪 CI Insights

Here's what we observed from your CI run for 2422797.

❌ Failed Jobs

Pipeline Job Health on base branch Retries 🔍 CI Insights 📄 Logs
CI [unit] storage (3.11, ubuntu-24.04) Broken 0 View View
unit-tests Broken 0 View View

@sonarqubecloud
Copy link

@giancarloromeo giancarloromeo removed this from the Voyager milestone Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:celery-library bug buggy, it does not work as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant