✨ Introduce streamed files search #8202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8202 +/- ##
==========================================
- Coverage 87.58% 87.58% -0.01%
==========================================
Files 2001 2003 +2
Lines 77978 78194 +216
Branches 1338 1344 +6
==========================================
+ Hits 68299 68484 +185
- Misses 9279 9309 +30
- Partials 400 401 +1
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
🧪 CI InsightsHere's what we observed from your CI run for 883cfd0. ✅ Passed Jobs With Interesting Signals
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new search functionality for files using wildcard patterns in the storage service. The feature allows users to search for files across projects using glob-style patterns like ".txt" or "data_".
- Adds a new REST endpoint
/v0/storage/locations/{location_id}/searchwith async job support - Implements wildcard-based file search functionality in the storage data manager
- Includes comprehensive test coverage for various search patterns and pagination
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
services/web/server/src/simcore_service_webserver/storage/_rest.py |
Adds new search endpoint handler with validation and async job integration |
services/web/server/src/simcore_service_webserver/api/v0/openapi.yaml |
Updates OpenAPI spec with new search endpoint and SearchBodyParams schema |
services/storage/src/simcore_service_storage/simcore_s3_dsm.py |
Implements core search functionality with S3 file pattern matching and pagination |
services/storage/src/simcore_service_storage/api/rpc/_simcore_s3.py |
Adds RPC interface for search task submission |
services/storage/src/simcore_service_storage/api/_worker_tasks/_simcore_s3.py |
Implements async search worker task |
packages/models-library/src/models_library/api_schemas_webserver/storage.py |
Defines SearchBodyParams schema |
packages/models-library/src/models_library/api_schemas_storage/search_async_jobs.py |
Defines SearchResult model for async job results |
services/storage/tests/unit/test_simcore_s3_dsm.py |
Comprehensive test suite for search functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
sanderegg
approved these changes
Oct 13, 2025
services/storage/src/simcore_service_storage/api/_worker_tasks/_simcore_s3.py
Show resolved
Hide resolved
giancarloromeo
requested review from
YuryHrytsuk and
mrnicegyu11
as code owners
wvangeit
approved these changes
Oct 14, 2025
giancarloromeo
changed the title
|
|
@Mergifyio queue |
🟠 Waiting for conditions to match
|
giancarloromeo
merged commit b781c6a
into
ITISFoundation:master
141 of 148 checks passed
This was referenced Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR adds a new search functionality for files using wildcard patterns in the storage service. The feature allows users to search for files across projects using glob-style patterns like ".txt" or "data_".
/v0/storage/locations/{location_id}:searchwith async job supportRelated issue/s
How to test
Dev-ops