🐛 Fix issue with agent and volume permissions when backing up #8214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 14, 2025 10:48
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8214 +/- ##
==========================================
- Coverage 88.08% 88.01% -0.08%
==========================================
Files 1910 1487 -423
Lines 73501 61112 -12389
Branches 1296 650 -646
==========================================
- Hits 64744 53787 -10957
+ Misses 8368 7094 -1274
+ Partials 389 231 -158
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
GitHK
added
a:services-library
…nt-permission-issue
Contributor
🧪 CI InsightsHere's what we observed from your CI run for e927433. ✅ Passed Jobs With Interesting Signals
|
GitHK
requested review from
bisgaard-itis,
Copilot,
giancarloromeo,
matusdrobuliak66,
mguidon and
sanderegg
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a permission issue with volume backups in the agent service by applying the same solution previously used in the dynamic-sidecar. The fix ensures proper file permissions before backing up volumes to prevent permission denied errors during rclone operations.
Key changes:
- Moved container utility functions from dynamic-sidecar to shared servicelib package
- Added permission fix to agent backup process using chmod command
- Updated imports across services to use the centralized container utilities
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| services/agent/src/simcore_service_agent/services/backup.py | Added permission fix function and logic to ensure readable permissions before backup |
| packages/service-library/src/servicelib/container_utils.py | Moved container execution utilities and error classes from dynamic-sidecar to shared library |
| services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/core/errors.py | Removed container execution error classes that were moved to servicelib |
| services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/modules/prometheus_metrics.py | Updated imports to use servicelib container utilities |
| services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/modules/long_running_tasks_utils.py | Updated imports to use servicelib container utilities |
| services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/api/rest/containers.py | Updated imports to use servicelib container utilities |
| services/agent/tests/unit/test_services_backup.py | Added mock container fixture for testing backup functionality |
| packages/service-library/tests/test_container_utils.py | Updated test imports to use servicelib container utilities |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fix issue with permissions inside
agent. The same issues was present before inside thedynamic-sidecar. Applying the same fix as before. Moved some command code toservicelib.Related issue/s
How to test
Dev-ops