Skip to content

✨ On first support message send email to fogbugz #8238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Aug 21, 2025
Merged

✨ On first support message send email to fogbugz #8238

merged 14 commits into from
Aug 21, 2025

Conversation

@matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented Aug 20, 2025 •
edited
Loading

What do these changes do?

  • ✨ When the first message is created in a support conversation, a FogBugz case is automatically generated (using the same email logic we already apply, for example, in account creation requests).

Related issue/s

How to test

Dev-ops

@matusdrobuliak66 matusdrobuliak66 self-assigned this Aug 20, 2025
@matusdrobuliak66 matusdrobuliak66 added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Aug 20, 2025
@codecov
Copy link

codecov bot commented Aug 20, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 62.50000% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.35%. Comparing base (dc6f3c8) to head (92cc88f).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8238      +/-   ##
==========================================
- Coverage   88.00%   85.35%   -2.66%     
==========================================
  Files        1916      743    -1173     
  Lines       74066    34324   -39742     
  Branches     1301      175    -1126     
==========================================
- Hits        65185    29298   -35887     
+ Misses       8490     4969    -3521     
+ Partials      391       57     -334
Flag Coverage Δ
integrationtests 63.98% <33.33%> (-0.01%) ⬇️
unittests 87.36% <62.50%> (+0.69%) ⬆️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 76.90% <ø> (-8.14%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 77.98% <ø> (-12.92%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 87.13% <ø> (-2.92%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 88.15% <62.50%> (+0.08%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc6f3c8...92cc88f. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matusdrobuliak66 matusdrobuliak66 added this to the Voyager milestone Aug 20, 2025
@mergify
Copy link
Contributor

mergify bot commented Aug 20, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for 92cc88f.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on base branch Retries 🔍 CI Insights 📄 Logs
CI unit-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

matusdrobuliak66 and others added 6 commits August 20, 2025 13:09
@matusdrobuliak66
send email to fogbugz
1216a42
@matusdrobuliak66
send email to fogbugz
1c1bc42
@matusdrobuliak66
send email to fogbugz
339cd1a
@matusdrobuliak66
send email to fogbugz add test
91420d2
@matusdrobuliak66
Adds Redis lock to support message creation for sync
f81aa73 
Introduces Redis-based exclusive locking to ensure atomicity
between message creation and first-message checking, preventing
race conditions in concurrent environments and maintaining
data consistency.
@matusdrobuliak66
Merge branch 'master' into create-case-in-fogbugz-via-email
695d7ef
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review August 20, 2025 12:32
@matusdrobuliak66 matusdrobuliak66 changed the title ✨ send email to fogbugz ✨ On first support message send email to fogbugz Aug 20, 2025
sanderegg
sanderegg approved these changes Aug 21, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

matusdrobuliak66 and others added 4 commits August 21, 2025 09:36
@matusdrobuliak66
Merge branch 'master' into create-case-in-fogbugz-via-email
4474c92
@matusdrobuliak66
Merge branch 'master' into create-case-in-fogbugz-via-email
1a95a73
@matusdrobuliak66
Merge branch 'create-case-in-fogbugz-via-email' of github.com:matusdr…
a6616cb 
…obuliak66/osparc-simcore into create-case-in-fogbugz-via-email
@matusdrobuliak66
Renames support message creation method for clarity
9d63834 
Improves code readability by updating the support message
creation function name to better reflect its purpose and
behavior when checking if the message is the first in
the conversation.
odeimaiz
odeimaiz approved these changes Aug 21, 2025
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@matusdrobuliak66 matusdrobuliak66 merged commit 5718eb4 into ITISFoundation:master Aug 21, 2025
91 of 95 checks passed
@matusdrobuliak66 matusdrobuliak66 deleted the create-case-in-fogbugz-via-email branch August 21, 2025 09:33
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 2, 2025
Closed
61 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 18, 2025
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@GitHK GitHK GitHK approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@sanderegg sanderegg sanderegg approved these changes

@pcrespov pcrespov Awaiting requested review from pcrespov pcrespov is a code owner

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@matusdrobuliak66 matusdrobuliak66

Labels

a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Milestone

Voyager

Development

Successfully merging this pull request may close these issues.

5 participants

@matusdrobuliak66 @giancarloromeo @GitHK @odeimaiz @sanderegg