Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg added this to the Voyager milestone Aug 22, 2025
@sanderegg sanderegg self-assigned this Aug 22, 2025
@sanderegg sanderegg added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Aug 22, 2025
@sanderegg sanderegg force-pushed the simultaneous-access/send-event-when-computation-completes branch from 943e8c8 to df5e3b6 Compare August 22, 2025 09:57
@codecov
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

❌ Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.85%. Comparing base (e873406) to head (2be91d9).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8250      +/-   ##
==========================================
- Coverage   88.04%   87.85%   -0.19%     
==========================================
  Files        1919     1756     -163     
  Lines       74325    70942    -3383     
  Branches     1305     1180     -125     
==========================================
- Hits        65437    62326    -3111     
+ Misses       8494     8253     -241     
+ Partials      394      363      -31     
Flag Coverage Δ
integrationtests 64.17% <95.65%> (+0.16%) ⬆️
unittests 86.43% <65.38%> (-0.24%) ⬇️
Components Coverage Δ
pkg_aws_library 93.93% <ø> (ø)
pkg_celery_library 87.37% <ø> (ø)
pkg_dask_task_models_library 79.62% <ø> (ø)
pkg_models_library 93.05% <66.66%> (+<0.01%) ⬆️
pkg_notifications_library 85.26% <ø> (ø)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.19% <ø> (ø)
pkg_service_library 72.35% <ø> (ø)
pkg_settings_library 90.17% <ø> (ø)
pkg_simcore_sdk 85.03% <ø> (ø)
agent 93.53% <ø> (ø)
api_server 92.84% <ø> (ø)
autoscaling 95.89% <ø> (ø)
catalog 92.34% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 92.37% <ø> (ø)
datcore_adapter 97.94% <ø> (ø)
director 75.81% <ø> (ø)
director_v2 90.85% <100.00%> (-0.21%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 90.10% <ø> (ø)
efs_guardian 89.62% <ø> (ø)
invitations 91.44% <ø> (ø)
payments 92.61% <ø> (ø)
resource_usage_tracker 91.76% <ø> (-0.48%) ⬇️
storage 86.40% <ø> (+0.12%) ⬆️
webclient ∅ <ø> (∅)
webserver 88.08% <100.00%> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e873406...2be91d9. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify
Copy link
Contributor

mergify bot commented Aug 22, 2025

🧪 CI Insights

Here's what we observed from your CI run for 2be91d9.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on base branch Retries 🔍 CI Insights 📄 Logs
CI [unit] api-server (3.11, ubuntu-24.04) Base branch is healthy, but retries were needed. Could be early signs of flakiness 👀 Healthy 1 View View
unit-tests Base branch is healthy, but retries were needed. Could be early signs of flakiness 👀 Healthy 1 View View

@sanderegg sanderegg force-pushed the simultaneous-access/send-event-when-computation-completes branch 4 times, most recently from 31e07da to 4d3c5ed Compare August 22, 2025 14:42
Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@sanderegg sanderegg force-pushed the simultaneous-access/send-event-when-computation-completes branch from ff77e05 to d3d6231 Compare August 25, 2025 09:29
@sanderegg sanderegg marked this pull request as ready for review August 25, 2025 09:29
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sanderegg sanderegg force-pushed the simultaneous-access/send-event-when-computation-completes branch 2 times, most recently from bfd3554 to 2935472 Compare August 25, 2025 15:22
@sanderegg sanderegg force-pushed the simultaneous-access/send-event-when-computation-completes branch from 90b78ae to 2be91d9 Compare August 25, 2025 19:43
@sonarqubecloud
Copy link

@sanderegg sanderegg merged commit 7881d83 into ITISFoundation:master Aug 26, 2025
145 of 148 checks passed
@sanderegg sanderegg deleted the simultaneous-access/send-event-when-computation-completes branch August 26, 2025 06:20
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 2, 2025
61 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When a computational pipeline finishes the NodeUpdate event for the dependent nodes are not unlocked

5 participants