✨ [Frontend] Expose phone number

[odeimaiz]

What do these changes do?

This PR exposes phone number to the frontend, particularly for 2FA SMS functionality and conditionally enables SMS 2FA based on whether a user has a phone number set.

It also refactors the handling of "everyone" groups to use centralized methods

Next step: let users update their phone number.

Without a Phone Number set:

With Phone Number set:

Related issue/s

• closes UI in https://github.com/ITISFoundation/private-issues/issues/280

How to test

Dev-ops

[mergify]

🧪 CI Insights

Here's what we observed from your CI run for 4f2c158.

🟢 All jobs passed!

But CI Insights is watching 👀

[Copilot]

Pull Request Overview

This PR adds phone number support to the frontend, particularly for 2FA SMS functionality. It refactors the handling of "everyone" groups to use centralized methods and conditionally enables SMS 2FA based on whether a user has a phone number set.

• Refactors hardcoded "everyone" group ID arrays to use centralized methods
• Adds phone number field to user profile when 2FA is required
• Conditionally enables SMS 2FA option based on phone number availability

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
osparc/ui/list/CollaboratorListItem.js	Replaces inline array with centralized method for getting everyone group IDs
osparc/store/Groups.js	Adds null safety checks and new methods for getting everyone groups/IDs
osparc/share/Collaborators.js	Refactors to use centralized everyone group ID method
osparc/desktop/account/ProfilePage.js	Adds phone number field and conditionally enables SMS 2FA
osparc/data/model/User.js	Adds phoneNumber property to User model
osparc/dashboard/StudyBrowser.js	Updates template filtering to use centralized everyone group methods
osparc/dashboard/CardBase.js	Refactors sharing logic to use centralized everyone group methods

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[giancarloromeo]

☎️

[pcrespov]

thx

suggestions:

• As a user, if I see the SMS disabled, i am not sure why and/or how to enable it. Instead of disabling SMS, why not prompt to enter a phone number if selected?
  • alternatively add a note on hover that says that it gets enabled when valid phone is provided
• If no phone, i would add background text help.
• Info icon with doc on hover: e.g. valid phone number used for 2FA etc ...

[pcrespov]

This must be a dev-feature i.e. can only show and be used if DEV_FEATURE is active

[odeimaiz]

This must be a dev-feature i.e. can only show and be used if DEV_FEATURE is active

@pcrespov Why is this a dev-feature?

[pcrespov]

This must be a dev-feature i.e. can only show and be used if DEV_FEATURE is active

@pcrespov Why is this a dev-feature?

We discussed it yesterday :-)
My PR #8106 marked the API endpoints as DEV_FEATURE, i.e. they will return NotImplemented error if this flag is off

The reason is that there is one part missing
I guess you can show the telephone (i.e. read) but cannot edit it (i.e. write) if DEV_FEATURE is not enabled

[odeimaiz]

This must be a dev-feature i.e. can only show and be used if DEV_FEATURE is active

@pcrespov Why is this a dev-feature?

We discussed it yesterday :-) My PR #8106 marked the API endpoints as DEV_FEATURE, i.e. they will return NotImplemented error if this flag is off

The reason is that there is one part missing I guess you can show the telephone (i.e. read) but cannot edit it (i.e. write) if DEV_FEATURE is not enabled

@pcrespov This is about showing it, no updating.

[pcrespov]

thx