Skip to content

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented Aug 25, 2025

What do these changes do?

Fixes the issue where invitations created through the PO center upon approval lacked product details and always wrongly defaulted to linking to the same product (i.e. the default) instead of the correct one.

Related issue/s

  • Reported by Mar in Mattermost during testing of the last deployment

How to test

🚨 In a deployment with multiple products

  1. Submit an account request via the form (pre-registration)
  2. Log in as a PO for that product and approve the request
  3. Verify in the PO center:
    • Invitation info shows the correct link and associated product(s)
  4. Verify the email content includes:
    • Correct logos/product details (product.vendor.ui)
    • Link to the product of origin (not the default)
  5. Click the invitation link and complete the registration flow
  6. Repeat the process with a different product within the same deployment

Dev-ops

  • test in master for several products by @pcrespov
  • test in staging for several products by @pcrespov
  • test in production for several products

@pcrespov pcrespov self-assigned this Aug 25, 2025
@codecov
Copy link

codecov bot commented Aug 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.38%. Comparing base (656c83d) to head (194eea0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8261      +/-   ##
==========================================
- Coverage   88.04%   85.38%   -2.67%     
==========================================
  Files        1919      744    -1175     
  Lines       74341    34419   -39922     
  Branches     1305      175    -1130     
==========================================
- Hits        65453    29387   -36066     
+ Misses       8495     4975    -3520     
+ Partials      393       57     -336     
Flag Coverage Δ
integrationtests 64.28% <50.00%> (-0.03%) ⬇️
unittests 87.35% <100.00%> (+0.67%) ⬆️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 76.84% <ø> (-8.20%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.13% <ø> (-12.82%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 87.19% <ø> (-2.91%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 88.12% <100.00%> (+0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 656c83d...194eea0. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pcrespov pcrespov changed the title WIP: Fix/invitations registration 🐛 Fix PO center invitations to include correct product info and links Aug 25, 2025
@pcrespov pcrespov added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Aug 25, 2025
@mergify
Copy link
Contributor

mergify bot commented Aug 25, 2025

🧪 CI Insights

Here's what we observed from your CI run for 194eea0.

🟢 All jobs passed!

But CI Insights is watching 👀

@pcrespov pcrespov force-pushed the fix/invitations-registration branch from a6ea8e1 to 3480287 Compare August 25, 2025 16:05
@pcrespov pcrespov added the High Priority a totally crucial bug/feature to be fixed asap label Aug 25, 2025
@pcrespov pcrespov added this to the Voyager milestone Aug 25, 2025
@pcrespov pcrespov marked this pull request as ready for review August 25, 2025 16:08
@pcrespov pcrespov enabled auto-merge (squash) August 25, 2025 16:08
@pcrespov pcrespov added the 🤖-automerge marks PR as ready to be merged for Mergify label Aug 25, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@pcrespov pcrespov requested a review from odeimaiz August 26, 2025 07:35
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@sonarqubecloud
Copy link

@pcrespov pcrespov merged commit 35e7048 into ITISFoundation:master Aug 26, 2025
92 of 95 checks passed
@pcrespov pcrespov deleted the fix/invitations-registration branch August 26, 2025 12:04
@pcrespov pcrespov changed the title 🐛 Fix PO center invitations to include correct product info and links 🐛 Fix PO center invitations to include correct product info and links (🚨) Aug 26, 2025
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 2, 2025
61 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:webserver webserver's codebase. Assigning the area is particularly useful for bugs High Priority a totally crucial bug/feature to be fixed asap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants