Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Sep 4, 2025

What do these changes do?

  • This PR allows OPS to change configurations of dask worker to start multiple processes, and also select threads
  • adds CLUSTERS_KEEPER_DASK_NPROCS ENV variable

Related issue/s

How to test

Dev-ops

@sanderegg sanderegg added this to the Cheops milestone Sep 4, 2025
@sanderegg sanderegg self-assigned this Sep 4, 2025
@sanderegg sanderegg added a:clusters-keeper 🤖-automerge marks PR as ready to be merged for Mergify labels Sep 4, 2025
@sanderegg sanderegg marked this pull request as ready for review September 4, 2025 08:08
@sanderegg
Copy link
Member Author

@mergify queue

@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.48%. Comparing base (66f73d3) to head (6467fb7).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8304      +/-   ##
==========================================
- Coverage   87.82%   87.48%   -0.35%     
==========================================
  Files        1945     1891      -54     
  Lines       75369    72979    -2390     
  Branches     1311     1311              
==========================================
- Hits        66192    63844    -2348     
+ Misses       8782     8740      -42     
  Partials      395      395              
Flag Coverage Δ
integrationtests 64.06% <ø> (+0.03%) ⬆️
unittests 86.36% <100.00%> (-0.13%) ⬇️
Components Coverage Δ
pkg_aws_library 93.59% <ø> (ø)
pkg_celery_library 87.37% <ø> (ø)
pkg_dask_task_models_library 79.62% <ø> (ø)
pkg_models_library 93.15% <ø> (ø)
pkg_notifications_library 85.20% <ø> (ø)
pkg_postgres_database 88.02% <ø> (ø)
pkg_service_integration 70.19% <ø> (ø)
pkg_service_library 71.13% <ø> (ø)
pkg_settings_library 90.17% <ø> (ø)
pkg_simcore_sdk 85.03% <ø> (ø)
agent 93.53% <ø> (ø)
api_server 91.91% <ø> (ø)
autoscaling 95.77% <ø> (ø)
catalog 92.34% <ø> (ø)
clusters_keeper 99.13% <100.00%> (+<0.01%) ⬆️
dask_sidecar 91.59% <ø> (-0.57%) ⬇️
datcore_adapter 97.94% <ø> (ø)
director 75.81% <ø> (ø)
director_v2 91.03% <ø> (+0.05%) ⬆️
dynamic_scheduler 96.27% <ø> (ø)
dynamic_sidecar 81.87% <ø> (-8.59%) ⬇️
efs_guardian 89.62% <ø> (ø)
invitations 91.44% <ø> (ø)
payments 92.61% <ø> (ø)
resource_usage_tracker 92.24% <ø> (+0.69%) ⬆️
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 87.99% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66f73d3...6467fb7. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify
Copy link
Contributor

mergify bot commented Sep 4, 2025

queue

🛑 Configuration not compatible with a branch protection setting

The branch protection setting Require branches to be up to date before merging is not compatible with max_parallel_checks>1, queue_conditions != merge_conditions and must be unset.

@mergify
Copy link
Contributor

mergify bot commented Sep 4, 2025

🧪 CI Insights

Here's what we observed from your CI run for 6467fb7.

❌ Job Failures

Pipeline Job Health on master Retries 🔍 CI Insights 📄 Logs
CI unit-tests Healthy 0 View View

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI system-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@sanderegg sanderegg force-pushed the clusters-keeper/add-variable-to-play-with-dask-nworkers branch 3 times, most recently from 5783721 to 46fc14a Compare September 4, 2025 15:29
@sanderegg sanderegg enabled auto-merge (squash) September 4, 2025 15:30
@sanderegg sanderegg force-pushed the clusters-keeper/add-variable-to-play-with-dask-nworkers branch 5 times, most recently from 8991513 to aef3041 Compare September 5, 2025 14:10
@sanderegg sanderegg force-pushed the clusters-keeper/add-variable-to-play-with-dask-nworkers branch from aef3041 to 6467fb7 Compare September 5, 2025 15:04
@sanderegg sanderegg disabled auto-merge September 5, 2025 15:04
@sanderegg sanderegg merged commit 479a6ab into ITISFoundation:master Sep 5, 2025
3 of 4 checks passed
@sanderegg sanderegg deleted the clusters-keeper/add-variable-to-play-with-dask-nworkers branch September 5, 2025 15:04
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 5, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:clusters-keeper

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants