β¨ Adding generic scheduling capability to dynamic-scheduler [part 1/2] #8307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 3, 2025 12:52
Codecov Reportβ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8307 +/- ##
==========================================
+ Coverage 87.83% 87.92% +0.09%
==========================================
Files 1964 1976 +12
Lines 76341 77220 +879
Branches 1342 1342
==========================================
+ Hits 67051 67897 +846
- Misses 8886 8919 +33
Partials 404 404
Continue to review full report in Codecov by Sentry.
π New features to boost your workflow:
|
π§ͺ CI InsightsHere's what we observed from your CI run for 6d78813. β Passed Jobs With Interesting Signals
|
added 18 commits
September 5, 2025 08:36
added 17 commits
September 29, 2025 13:49
pcrespov
approved these changes
Sep 29, 2025
There was a problem hiding this comment.
This is too long for me to review in full detail. TBH I donβt fully understand all of the logic, but it seems this is still inactive after this PR, so I donβt think we should delay it further. Hopefully the other colleagues can review the remaining parts.
services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/api/rest/_ops.py
Show resolved
Hide resolved
added 2 commits
October 1, 2025 08:38
β¦-dy-scheduler-part2
|
giancarloromeo
changed the title
giancarloromeo
changed the title
giancarloromeo
approved these changes
Oct 1, 2025
This was referenced Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Please π do not panic! There is a lot of code but the core of it composed of 1000 lines, where most of the attention is required.
Suggested review order: focus your review starting from
services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/services/generic_scheduler/in the following order:_api.pyto have an idea of the methods the scheduler exposes_core.pyand look directly at_on_schedule_evenwhich introduces the logic behind the scheduler worksOperationlook at_operation.py, it might make more sense to read it form the bottom to the topThere is test coverage for all modules, for some it's pretty extensive.
This is the first of two PRs, The second one will bring a much required interface for monitoring the status of the scheduler.
The
generic_schedulermodule is the core of thedynamic-schedulerservice and was built to take into consideration some important requirements:During the last years it became apparent that we needed more flexibility during the starting and and closing of services. The idea here is to have a robust system that runs as much as possible without human intervention that can be easily debugged in case of issues.
Related issue/s
How to test
Dev-ops