Skip to content

Conversation

@wvangeit
Copy link
Contributor

@wvangeit wvangeit commented Sep 4, 2025

What do these changes do?

After this PR:
#8278
The osparc python client was not building anymore.
The autogenerated code contained too long filenames.
I added an explicit class for a return type instead of an alias to force a shorter name.

Related issue/s

How to test

Build python client based on this PR's openapi.json

Dev-ops

No changes

@wvangeit wvangeit added this to the Cheops milestone Sep 4, 2025
@wvangeit wvangeit self-assigned this Sep 4, 2025
@wvangeit wvangeit added a:apiserver api-server service 🤖-automerge marks PR as ready to be merged for Mergify labels Sep 4, 2025
@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.03%. Comparing base (d7ee297) to head (1e7750e).
⚠️ Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (d7ee297) and HEAD (1e7750e). Click for more details.

HEAD has 31 uploads less than BASE
Flag BASE (d7ee297) HEAD (1e7750e)
unittests 32 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #8309       +/-   ##
===========================================
- Coverage   87.62%   69.03%   -18.60%     
===========================================
  Files        1940      875     -1065     
  Lines       75325    39282    -36043     
  Branches     1311      175     -1136     
===========================================
- Hits        66006    27119    -38887     
- Misses       8924    12106     +3182     
+ Partials      395       57      -338     
Flag Coverage Δ
integrationtests 64.05% <ø> (-9.37%) ⬇️
unittests 91.93% <100.00%> (+5.42%) ⬆️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 76.90% <ø> (-8.14%) ⬇️
agent ∅ <ø> (∅)
api_server 91.93% <100.00%> (+<0.01%) ⬆️
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.13% <ø> (-12.92%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 81.87% <ø> (-8.59%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 58.91% <ø> (-28.36%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7ee297...1e7750e. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify
Copy link
Contributor

mergify bot commented Sep 4, 2025

🧪 CI Insights

Here's what we observed from your CI run for 1e7750e.

🟢 All jobs passed!

But CI Insights is watching 👀

@wvangeit wvangeit marked this pull request as ready for review September 4, 2025 12:13
@wvangeit wvangeit requested a review from pcrespov as a code owner September 4, 2025 12:13
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 4, 2025

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@wvangeit
Copy link
Contributor Author

wvangeit commented Sep 4, 2025

@mergify queue

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@mergify
Copy link
Contributor

mergify bot commented Sep 4, 2025

queue

🛑 Configuration not compatible with a branch protection setting

The branch protection setting Require branches to be up to date before merging is not compatible with max_parallel_checks>1, queue_conditions != merge_conditions and must be unset.

@wvangeit wvangeit merged commit 1ccb606 into ITISFoundation:master Sep 4, 2025
90 of 95 checks passed
@wvangeit wvangeit deleted the fix_python_client branch September 4, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:apiserver api-server service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants