🎨E2E: add create study, create function, start mmux #8311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
force-pushed
the
e2e/create-function
branch
from
4656f5e to
1312e37
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8311 +/- ##
==========================================
- Coverage 87.82% 85.99% -1.84%
==========================================
Files 1945 1891 -54
Lines 75517 73126 -2391
Branches 1312 1312
==========================================
- Hits 66323 62884 -3439
- Misses 8799 9847 +1048
Partials 395 395
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
sanderegg
force-pushed
the
e2e/create-function
branch
from
1312e37 to
c718e74
Compare
🧪 CI InsightsHere's what we observed from your CI run for a78953b. ✅ Passed Jobs With Interesting Signals
|
sanderegg
force-pushed
the
e2e/create-function
branch
from
c29b7f9 to
e882a78
Compare
sanderegg
changed the title
sanderegg
requested review from
JavierGOrdonnez,
alexpargon,
bisgaard-itis,
giancarloromeo,
odeimaiz,
pcrespov and
wvangeit
There was a problem hiding this comment.
Pull Request Overview
This PR adds an end-to-end test for metamodeling functionality, specifically for response surface modeling (RSM). The test creates a study, converts it to a function, and then starts an RSM service to use that function.
- Adds a fixture to create functions from projects with proper cleanup
- Implements a multi-step E2E test that creates a study, converts it to a function, and starts RSM
- Modifies the project cleanup logic to handle cases where the dashboard button is not visible
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/e2e-playwright/tests/metamodeling/test_response_surface_modeling.py | Adds fixture for function creation and implements comprehensive E2E test workflow |
| tests/e2e-playwright/tests/conftest.py | Updates project cleanup logic to handle dashboard visibility and removes single-project restriction |
Comments suppressed due to low confidence (1)
tests/e2e-playwright/tests/conftest.py:1
- The removal of this assertion allows multiple projects to be created simultaneously, which could lead to unexpected behavior or resource conflicts. Consider adding a parameter to explicitly control whether multiple projects are allowed, or document why this restriction was removed.
# pylint: disable=no-name-in-module
tests/e2e-playwright/tests/metamodeling/test_response_surface_modeling.py
Show resolved
Hide resolved
tests/e2e-playwright/tests/metamodeling/test_response_surface_modeling.py
Show resolved
Hide resolved
sanderegg
force-pushed
the
e2e/create-function
branch
from
e882a78 to
a78953b
Compare
|
odeimaiz
approved these changes
Sep 9, 2025
16 tasks
This was referenced Sep 18, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR brings:
Still needs:
@alexpargon I would need some
osparc-test-idin the mmux frontend if possibleRelated issue/s
How to test
Dev-ops