Skip to content

🎨 Enhance account request emails to reduce invitation errors #8317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2025
Merged

🎨 Enhance account request emails to reduce invitation errors #8317

merged 2 commits into from
Sep 5, 2025

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented Sep 5, 2025

What do these changes do?

Improves the formatting of account request emails by clearly highlighting the target product and host.

image

This change reduces the risk of manual errors when issuing invitations, such as sending them to the wrong host or product.

Related issue/s

  • Follow-up improvement to minimize invitation mistakes.

How to test

  • Fill up request form
  • Support email list will receive new formatted email

Dev-ops

None

@pcrespov pcrespov self-assigned this Sep 5, 2025
@pcrespov pcrespov added the a:doc documentation, reporting, admin tasks label Sep 5, 2025
@pcrespov pcrespov enabled auto-merge (squash) September 5, 2025 09:04
@pcrespov
Copy link
Member Author

pcrespov commented Sep 5, 2025

@mergify queue

@pcrespov pcrespov added this to the Cheops milestone Sep 5, 2025
@pcrespov pcrespov added the t:maintenance Some planned maintenance work label Sep 5, 2025
Copilot AI reviewed Sep 5, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the formatting of account request emails to make product and host information more prominent and reduce manual errors when processing account requests. The changes improve visual clarity by restructuring how product and host details are displayed.

Key Changes

  • Reformats email templates to use bullet points and bold formatting for better visibility
  • Standardizes the presentation across HTML and text email formats
  • Maintains all existing functionality while improving readability

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
services/web/server/src/simcore_service_webserver/templates/common/request_account.jinja2 Updates HTML email template to use ordered list format with bold highlighting for product and host
packages/notifications-library/src/notifications_library/templates/on_account_requested.email.content.txt Updates plain text email template to use bullet points with bold formatting
packages/notifications-library/src/notifications_library/templates/on_account_requested.email.content.html Updates HTML email template to use ordered list format with bold highlighting

@mergify
Copy link
Contributor

mergify bot commented Sep 5, 2025 •
edited
Loading

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
        • check-success = check OAS' are up to date
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
      • any of: [🛡 GitHub branch protection]
        • check-success = SonarCloud Code Analysis
        • check-neutral = SonarCloud Code Analysis
        • check-skipped = SonarCloud Code Analysis
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

@codecov
Copy link

codecov bot commented Sep 5, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.81%. Comparing base (9149e41) to head (728758d).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8317      +/-   ##
==========================================
+ Coverage   84.72%   89.81%   +5.08%     
==========================================
  Files        1771     1328     -443     
  Lines       68513    55827   -12686     
  Branches     1311      193    -1118     
==========================================
- Hits        58046    50139    -7907     
+ Misses      10086     5619    -4467     
+ Partials      381       69     -312
Flag Coverage Δ
integrationtests 64.06% <ø> (+3.13%) ⬆️
unittests 88.00% <ø> (+3.42%) ⬆️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library 85.20% <ø> (ø)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.03% <ø> (+19.74%) ⬆️
agent 93.53% <ø> (ø)
api_server 91.91% <ø> (∅)
autoscaling 95.77% <ø> (ø)
catalog 92.34% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 92.37% <ø> (ø)
datcore_adapter 97.94% <ø> (ø)
director 75.81% <ø> (ø)
director_v2 91.03% <ø> (+5.60%) ⬆️
dynamic_scheduler 96.27% <ø> (ø)
dynamic_sidecar 90.46% <ø> (-0.03%) ⬇️
efs_guardian 89.62% <ø> (ø)
invitations 91.44% <ø> (ø)
payments 92.61% <ø> (ø)
resource_usage_tracker 92.24% <ø> (+0.05%) ⬆️
storage 86.57% <ø> (∅)
webclient ∅ <ø> (∅)
webserver 87.99% <ø> (+5.57%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9149e41...728758d. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify
Copy link
Contributor

mergify bot commented Sep 5, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for 728758d.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI system-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

@pcrespov pcrespov disabled auto-merge September 5, 2025 14:27
@pcrespov pcrespov merged commit 66f73d3 into ITISFoundation:master Sep 5, 2025
2 of 4 checks passed
@pcrespov pcrespov deleted the mai/change-template branch September 5, 2025 14:28
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pcrespov pcrespov mentioned this pull request Sep 11, 2025
Closed
16 tasks
This was referenced Sep 18, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@GitHK GitHK GitHK approved these changes

@sanderegg sanderegg sanderegg approved these changes

@JavierGOrdonnez JavierGOrdonnez JavierGOrdonnez approved these changes

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66 matusdrobuliak66 is a code owner

@eofli eofli Awaiting requested review from eofli

Assignees

@pcrespov pcrespov

Labels

a:doc documentation, reporting, admin tasks t:maintenance Some planned maintenance work

Projects

None yet

Milestone

Cheops

Development

Successfully merging this pull request may close these issues.

4 participants

@pcrespov @GitHK @sanderegg @JavierGOrdonnez