🎨 added docker hub registry auth to director-v2 when creating services ⚠️

[GitHK]

What do these changes do?

Adds authentication when services are created via director-v2. This was missing and was causing images on Docker Hub to not be used.

Related issue/s

How to test

Dev-ops ⚠️

• currently on all our deployments the DIRECTOR_V2_DOCKER_HUB_REGISTRY={} which means it loads the credentials for our internal registry. Please change this so it uses the appropriate settings @YuryHrytsuk

[Copilot]

Pull Request Overview

This PR adds Docker Hub registry authentication to the director-v2 service creation process. The main purpose is to enable authentication when pulling Docker images from Docker Hub, which was previously missing and causing failures when trying to use images from Docker Hub.

• Adds authentication support to the create_service_and_get_id function
• Updates all test calls to include the new authentication parameter
• Modifies the service creation logic in the scheduler to pass Docker Hub registry settings

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/docker_api/_core.py	Updates the core service creation function to accept and use Docker Hub registry authentication settings
services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_event_create_sidecars.py	Modifies the scheduler to pass app settings for Docker Hub authentication when creating services
services/director-v2/tests/unit/with_dbs/test_modules_dynamic_sidecar_docker_api.py	Updates all test calls to include the new authentication parameter with None values

[codecov]

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.77%. Comparing base (d443f36) to head (fd5255e).

❗ There is a different number of reports uploaded between BASE (d443f36) and HEAD (fd5255e). Click for more details.

HEAD has 30 uploads less than BASE

Flag	BASE (d443f36)	HEAD (fd5255e)
unittests	31	1

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #8321       +/-   ##
===========================================
- Coverage   89.58%   68.77%   -20.81%     
===========================================
  Files        1744      760      -984     
  Lines       68230    34871    -33359     
  Branches      828      175      -653     
===========================================
- Hits        61124    23983    -37141     
- Misses       6886    10831     +3945     
+ Partials      220       57      -163     

Flag	Coverage Δ
integrationtests	64.08% <80.00%> (+0.01%)	⬆️
unittests	84.55% <30.00%> (-3.56%)	⬇️

Components	Coverage Δ
pkg_aws_library	∅ <ø> (∅)
pkg_celery_library	∅ <ø> (∅)
pkg_dask_task_models_library	∅ <ø> (∅)
pkg_models_library	∅ <ø> (∅)
pkg_notifications_library	∅ <ø> (∅)
pkg_postgres_database	∅ <ø> (∅)
pkg_service_integration	∅ <ø> (∅)
pkg_service_library	∅ <ø> (∅)
pkg_settings_library	∅ <ø> (∅)
pkg_simcore_sdk	76.84% <ø> (-8.14%)	⬇️
agent	∅ <ø> (∅)
api_server	∅ <ø> (∅)
autoscaling	∅ <ø> (∅)
catalog	∅ <ø> (∅)
clusters_keeper	∅ <ø> (∅)
dask_sidecar	∅ <ø> (∅)
datcore_adapter	∅ <ø> (∅)
director	∅ <ø> (∅)
director_v2	90.99% <80.00%> (-0.07%)	⬇️
dynamic_scheduler	∅ <ø> (∅)
dynamic_sidecar	81.87% <ø> (-8.59%)	⬇️
efs_guardian	∅ <ø> (∅)
invitations	∅ <ø> (∅)
payments	∅ <ø> (∅)
resource_usage_tracker	∅ <ø> (∅)
storage	∅ <ø> (∅)
webclient	∅ <ø> (∅)
webserver	58.96% <ø> (-29.04%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d443f36...fd5255e. Read the comment docs.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mergify]

🧪 CI Insights

Here's what we observed from your CI run for fd5255e.

✅ Passed Jobs With Interesting Signals

Pipeline	Job	Signal	Health on master	Retries	🔍 CI Insights	📄 Logs
CI	unit-tests	Base branch is broken, but the job passed. Looks like this might be a real fix 💪		0	View	View

[YuryHrytsuk]

Thanks!

[sanderegg]

thanks

[bisgaard-itis]

Thanks 👍🏻

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud