Add a check_write_permissions option to update function job/out 🐛 #8325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvangeit
added
the
a:webserver
wvangeit
requested review from
GitHK,
matusdrobuliak66 and
sanderegg
as code owners
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8325 +/- ##
==========================================
+ Coverage 85.12% 87.69% +2.57%
==========================================
Files 1825 1520 -305
Lines 70906 62779 -8127
Branches 1311 658 -653
==========================================
- Hits 60362 55057 -5305
+ Misses 10149 7489 -2660
+ Partials 395 233 -162
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
🧪 CI InsightsHere's what we observed from your CI run for c68204c. 🟢 All jobs passed!But CI Insights is watching 👀 |
sanderegg
approved these changes
Sep 8, 2025
services/web/server/src/simcore_service_webserver/functions/_functions_repository.py
Show resolved
Hide resolved
pcrespov
reviewed
Sep 8, 2025
services/web/server/src/simcore_service_webserver/functions/_functions_repository.py
Outdated
Show resolved
Hide resolved
|
@mergify queue |
🛑 Configuration not compatible with a branch protection settingThe branch protection setting |
|
16 tasks
This was referenced Sep 18, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
While using the caching ability of function job status/output, there was an issue when a user only has read permission for function jobs. The repository layer was refusing to update the status/output coming from the comp backend in the db, used as cache, since the user didn't have write permission. I added an option to the update call to ignore the write permissions (the user can't control what is being written, the values are always coming from the comp backend)
Related issue/s
How to test
Give a user read-only access to a function job. Let user get status/output of the function job. This should succeed now.
Dev-ops
No changes