-
Notifications
You must be signed in to change notification settings - Fork 32
🎨 [Frontend] Event-driven patch regardless of whether RTC is enabled #8328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 [Frontend] Event-driven patch regardless of whether RTC is enabled #8328
Conversation
🧪 CI InsightsHere's what we observed from your CI run for 7b816fc. ✅ Passed Jobs With Interesting Signals
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR simplifies the frontend codebase by removing the dual-path system for handling study document updates. It standardizes on the event-driven patch mechanism regardless of whether Real-Time Collaboration (RTC) is enabled, eliminating the legacy auto-save timer and polling-based approach.
- Removes the
eventDrivenPatch()utility function and its conditional logic throughout the codebase - Eliminates auto-save timers and saving timers that were used for the non-event-driven approach
- Consolidates node change handling to use only the event-driven
projectDocumentChangedmechanism
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| osparc/utils/Utils.js | Removes the eventDrivenPatch() function that determined which update mechanism to use |
| osparc/desktop/StudyEditor.js | Removes auto-save and saving timer functionality, simplifies initialization logic |
| osparc/data/model/Workbench.js | Removes deprecated deserialization methods and timer-related event listeners |
| osparc/data/model/Node.js | Removes legacy updateStudyDocument event and moves listenToChanges() call |
| osparc/workbench/WorkbenchUI.js | Adds check for auto-start disabled setting in double-tap handler |
| osparc/node/LifeCycleView.js | Replaces legacy event with event-driven patch mechanism |
| osparc/node/BootOptionsView.js | Removes legacy updateStudyDocument event fire |
services/static-webserver/client/source/class/osparc/data/model/Workbench.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup! Thanks 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
|
@Mergifyio queue |
🛑 Configuration not compatible with a branch protection settingThe branch protection setting |



What do these changes do?
This PR simplifies the frontend codebase by removing the dual-path system for handling study document updates. It standardizes on the event-driven patch mechanism regardless of whether Real-Time Collaboration (RTC) is enabled, eliminating the legacy auto-save timer and polling-based approach.
Related issue/s
How to test
Dev-ops