🐛 [Frontend] Add new parameter from node's inputs #8332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
bug
|
There was a problem hiding this comment.
Pull Request Overview
This PR extends functionality to support pipeline mode alongside workbench mode for file-related operations and UI visibility. The changes enable file selection buttons, progress bars, and file browser layouts to be visible in both workbench and pipeline modes.
Key changes:
- Updated visibility conditions to include both "workbench" and "pipeline" modes
- Added widget ID for study title renamer component
- Extended file picker layout support for pipeline mode
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| StudyTitleWOptions.js | Added widget ID assignment for study title renamer |
| PropForm.js | Updated visibility conditions to include pipeline mode for file buttons and parameter menu buttons |
| FilePicker.js | Extended workbench layout usage to pipeline mode |
| WorkbenchView.js | Updated file request handling to include pipeline mode |
odeimaiz
requested review from
GitHK,
bisgaard-itis,
giancarloromeo,
pcrespov and
sanderegg
pcrespov
approved these changes
Sep 8, 2025
16 tasks
This was referenced Sep 18, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Bug found by @sanderegg
Fix: This PR extends functionality to support
pipelinemode alongsideworkbenchui-mode for displaying "Add new parameter" button.Bonus:
studyTitleRenamerRelated issue/s
How to test
Dev-ops