🎨 [Frontend] Distinguish product groups (Everyone/Public and Support) #8335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
🧪 CI InsightsHere's what we observed from your CI run for 7469de8. ✅ Passed Jobs With Interesting Signals
|
There was a problem hiding this comment.
Pull Request Overview
This PR implements visual distinction between product groups (Everyone/Public and Support) and regular groups in the frontend interface. The changes add visual separators and reorder collaborators to prioritize product-related groups.
Key changes:
- Introduces a standardized ordering system for collaboration types
- Adds visual separators between product groups and other groups in various UI components
- Updates icons for better visual distinction of support groups
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
osparc/theme/Decoration.js |
Adds "separator-strong" decoration style for visual separation |
osparc/store/Groups.js |
Defines collaboration type ordering array for consistent sorting |
osparc/share/Collaborators.js |
Implements product group sorting and separator insertion logic |
osparc/filter/OrganizationsAndMembers.js |
Updates to use centralized collaboration type ordering |
osparc/filter/CollaboratorToggleButton.js |
Adds icon width standardization for alignment |
osparc/desktop/organizations/OrganizationsList.js |
Adds separator logic and safe property access |
osparc/data/model/Group.js |
Fixes syntax error in statics object |
osparc/dashboard/CardBase.js |
Updates support group icon |
services/static-webserver/client/source/class/osparc/data/model/Group.js
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/desktop/organizations/OrganizationsList.js
Show resolved
Hide resolved
odeimaiz
requested review from
GitHK,
bisgaard-itis,
giancarloromeo,
pcrespov and
sanderegg
|
@mergify queue |
🛑 Configuration not compatible with a branch protection settingThe branch protection setting |
pcrespov
approved these changes
Sep 9, 2025
…osparc-simcore into enh/distinguish-product-groups
|
16 tasks
This was referenced Sep 18, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR implements visual distinction between product groups (Everyone/Public and Support) and regular groups in the frontend interface. The changes add visual separators and reorder collaborators to prioritize product-related groups.
Bonus:
Related issue/s
How to test
Dev-ops