- 
                Notifications
    
You must be signed in to change notification settings  - Fork 32
 
✨ [Frontend] Support users can access other users extra data #8339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [Frontend] Support users can access other users extra data #8339
Conversation
          
🧪 CI InsightsHere's what we observed from your CI run for 31d1b6b. ✅ Passed Jobs With Interesting Signals
  | 
    
…z/osparc-simcore into feature/supporter-searches-users
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements support for users to access and view other users' extended profile data. The change introduces a comprehensive user profile viewer with detailed contact information and styling improvements.
Key changes:
- Enhanced user details dialog to show complete profile information including contact details
 - Added JSON formatter widget for displaying additional user data
 - Refactored username to userName throughout the codebase for consistency
 
Reviewed Changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description | 
|---|---|
| services/static-webserver/client/source/class/osparc/wrapper/JsonFormatter.js | Added error handling and custom styling for JSON formatter | 
| services/static-webserver/client/source/class/osparc/widget/JsonFormatterWidget.js | New widget component for rendering JSON data with custom styling | 
| services/static-webserver/client/source/class/osparc/user/UserDetails.js | Major refactor to show comprehensive user profile with contact information | 
| services/static-webserver/client/source/class/osparc/data/model/User.js | Updated property names and added contact data handling methods | 
| services/static-webserver/client/source/class/osparc/data/Resources.js | Added new API endpoint for searching users by group ID | 
| Multiple files | Systematic renaming from username to userName for consistency | 
        
          
                services/static-webserver/client/source/class/osparc/user/UserDetails.js
          
            Show resolved
            Hide resolved
        
              
          
                services/static-webserver/client/source/class/osparc/auth/ui/LoginView.js
          
            Show resolved
            Hide resolved
        
              
          
                services/static-webserver/client/source/class/osparc/desktop/account/ProfilePage.js
          
            Show resolved
            Hide resolved
        
      …z/osparc-simcore into feature/supporter-searches-users
| 
           @mergify queue  | 
    
          
 🛑 Configuration not compatible with a branch protection settingThe branch protection setting   | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
Some suggestions:
- auto-create nice titles from field name e.g. 
preRegistrationID -> "Pre Registration ID" 
- TIP2: from the openapi specs you can also get descriptions of these fields  https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/ITISFoundation/osparc-simcore/refs/heads/master/services/web/server/src/simcore_service_webserver/api/v0/openapi.yaml#tag/admin/operation/list_users_accounts  (NOTE that you have access from the front-end to the entire 
openapi.json) 
      
    | 
           @mergify queue  | 
    
          
 🛑 Configuration not compatible with a branch protection settingThe branch protection setting   | 
    
          
 | 
    



What do these changes do?
This PR implements a extended user details view for support users.
Related issue/s
How to test
Dev-ops