Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 9, 2025

What do these changes do?

This PR implements a extended user details view for support users.

ExtendedInformation

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz self-assigned this Sep 9, 2025
@odeimaiz odeimaiz added this to the Cheops milestone Sep 9, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Sep 9, 2025
@mergify
Copy link
Contributor

mergify bot commented Sep 9, 2025

🧪 CI Insights

Here's what we observed from your CI run for 31d1b6b.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI system-tests Base branch is broken, but retries were needed. Could be early signs of flakiness 👀 Broken 1 View View
unit-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

@odeimaiz odeimaiz requested a review from Copilot September 10, 2025 11:19
@odeimaiz odeimaiz marked this pull request as ready for review September 10, 2025 11:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements support for users to access and view other users' extended profile data. The change introduces a comprehensive user profile viewer with detailed contact information and styling improvements.

Key changes:

  • Enhanced user details dialog to show complete profile information including contact details
  • Added JSON formatter widget for displaying additional user data
  • Refactored username to userName throughout the codebase for consistency

Reviewed Changes

Copilot reviewed 32 out of 32 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
services/static-webserver/client/source/class/osparc/wrapper/JsonFormatter.js Added error handling and custom styling for JSON formatter
services/static-webserver/client/source/class/osparc/widget/JsonFormatterWidget.js New widget component for rendering JSON data with custom styling
services/static-webserver/client/source/class/osparc/user/UserDetails.js Major refactor to show comprehensive user profile with contact information
services/static-webserver/client/source/class/osparc/data/model/User.js Updated property names and added contact data handling methods
services/static-webserver/client/source/class/osparc/data/Resources.js Added new API endpoint for searching users by group ID
Multiple files Systematic renaming from username to userName for consistency

@odeimaiz odeimaiz added the 🤖-automerge marks PR as ready to be merged for Mergify label Sep 10, 2025
@odeimaiz
Copy link
Member Author

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Sep 10, 2025

queue

🛑 Configuration not compatible with a branch protection setting

The branch protection setting Require branches to be up to date before merging is not compatible with max_parallel_checks>1, queue_conditions != merge_conditions and must be unset.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Some suggestions:

  • auto-create nice titles from field name e.g. preRegistrationID -> "Pre Registration ID"
image image

@odeimaiz
Copy link
Member Author

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Sep 10, 2025

queue

🛑 Configuration not compatible with a branch protection setting

The branch protection setting Require branches to be up to date before merging is not compatible with max_parallel_checks>1, queue_conditions != merge_conditions and must be unset.

@sonarqubecloud
Copy link

@odeimaiz odeimaiz merged commit c4cb923 into ITISFoundation:master Sep 10, 2025
108 of 110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants