Skip to content

Conversation

@wvangeit
Copy link
Contributor

@wvangeit wvangeit commented Sep 10, 2025

What do these changes do?

A new field was added to the function jobs to store the celery task id. However, this is not present in existing entities, which generates 500 errors in production atm.
I'm creating this small PR to be applied as a hotfix to handle that case.
By using get() in the dictionary the value will default to None.

How to test

Test code on deployment that has old function job entities

Dev-ops

No changes
To be hotfixed in production.

@wvangeit wvangeit added a:webserver webserver's codebase. Assigning the area is particularly useful for bugs πŸ€–-automerge marks PR as ready to be merged for Mergify labels Sep 10, 2025
@wvangeit
Copy link
Contributor Author

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Sep 10, 2025

queue

πŸ›‘ Configuration not compatible with a branch protection setting

The branch protection setting Require branches to be up to date before merging is not compatible with max_parallel_checks>1, queue_conditions != merge_conditions and must be unset.

@codecov
Copy link

codecov bot commented Sep 10, 2025

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 84.80%. Comparing base (7a4e794) to head (351ac02).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8347      +/-   ##
==========================================
- Coverage   86.76%   84.80%   -1.97%     
==========================================
  Files        1771      760    -1011     
  Lines       68674    34985   -33689     
  Branches     1312      175    -1137     
==========================================
- Hits        59585    29669   -29916     
+ Misses       8694     5259    -3435     
+ Partials      395       57     -338     
Flag Coverage Ξ”
integrationtests 64.03% <ΓΈ> (+0.84%) ⬆️
unittests 87.23% <ΓΈ> (+1.10%) ⬆️
Components Coverage Ξ”
pkg_aws_library βˆ… <ΓΈ> (βˆ…)
pkg_celery_library βˆ… <ΓΈ> (βˆ…)
pkg_dask_task_models_library βˆ… <ΓΈ> (βˆ…)
pkg_models_library βˆ… <ΓΈ> (βˆ…)
pkg_notifications_library βˆ… <ΓΈ> (βˆ…)
pkg_postgres_database βˆ… <ΓΈ> (βˆ…)
pkg_service_integration βˆ… <ΓΈ> (βˆ…)
pkg_service_library βˆ… <ΓΈ> (βˆ…)
pkg_settings_library βˆ… <ΓΈ> (βˆ…)
pkg_simcore_sdk 76.95% <ΓΈ> (-8.08%) ⬇️
agent βˆ… <ΓΈ> (βˆ…)
api_server βˆ… <ΓΈ> (βˆ…)
autoscaling βˆ… <ΓΈ> (βˆ…)
catalog βˆ… <ΓΈ> (βˆ…)
clusters_keeper βˆ… <ΓΈ> (βˆ…)
dask_sidecar βˆ… <ΓΈ> (βˆ…)
datcore_adapter βˆ… <ΓΈ> (βˆ…)
director βˆ… <ΓΈ> (βˆ…)
director_v2 78.16% <ΓΈ> (-7.19%) ⬇️
dynamic_scheduler βˆ… <ΓΈ> (βˆ…)
dynamic_sidecar 81.87% <ΓΈ> (-8.59%) ⬇️
efs_guardian βˆ… <ΓΈ> (βˆ…)
invitations βˆ… <ΓΈ> (βˆ…)
payments βˆ… <ΓΈ> (βˆ…)
resource_usage_tracker βˆ… <ΓΈ> (βˆ…)
storage βˆ… <ΓΈ> (βˆ…)
webclient βˆ… <ΓΈ> (βˆ…)
webserver 87.99% <ΓΈ> (+0.77%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 7a4e794...351ac02. Read the comment docs.

πŸš€ New features to boost your workflow:
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@mergify
Copy link
Contributor

mergify bot commented Sep 10, 2025

πŸ§ͺ CI Insights

Here's what we observed from your CI run for 351ac02.

🟒 All jobs passed!

But CI Insights is watching πŸ‘€

@sonarqubecloud
Copy link

@wvangeit wvangeit merged commit 96d5805 into ITISFoundation:master Sep 10, 2025
93 of 95 checks passed
@wvangeit wvangeit deleted the fix_task_id_not_found branch September 10, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

πŸ€–-automerge marks PR as ready to be merged for Mergify a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants