-
Notifications
You must be signed in to change notification settings - Fork 32
Fix job_task_id not found if db doesnt have the field π ποΈ #8347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix job_task_id not found if db doesnt have the field π ποΈ #8347
Conversation
|
@mergify queue |
π Configuration not compatible with a branch protection settingThe branch protection setting |
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8347 +/- ##
==========================================
- Coverage 86.76% 84.80% -1.97%
==========================================
Files 1771 760 -1011
Lines 68674 34985 -33689
Branches 1312 175 -1137
==========================================
- Hits 59585 29669 -29916
+ Misses 8694 5259 -3435
+ Partials 395 57 -338
Continue to review full report in Codecov by Sentry.
π New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
services/web/server/src/simcore_service_webserver/functions/_functions_service.py
Show resolved
Hide resolved
π§ͺ CI InsightsHere's what we observed from your CI run for 351ac02. π’ All jobs passed!But CI Insights is watching π |
|



What do these changes do?
A new field was added to the function jobs to store the celery task id. However, this is not present in existing entities, which generates 500 errors in production atm.
I'm creating this small PR to be applied as a hotfix to handle that case.
By using get() in the dictionary the value will default to None.
How to test
Test code on deployment that has old function job entities
Dev-ops
No changes
To be hotfixed in production.