-
Notifications
You must be signed in to change notification settings - Fork 32
🎨 Makes removal of long running tasks faster #8350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Makes removal of long running tasks faster #8350
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8350 +/- ##
==========================================
+ Coverage 87.86% 87.88% +0.01%
==========================================
Files 1945 1945
Lines 75630 75623 -7
Branches 1321 1322 +1
==========================================
+ Hits 66456 66459 +3
+ Misses 8776 8767 -9
+ Partials 398 397 -1
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! looking forward
packages/pytest-simcore/src/pytest_simcore/helpers/long_running_tasks.py
Outdated
Show resolved
Hide resolved
packages/service-library/src/servicelib/long_running_tasks/task.py
Outdated
Show resolved
Hide resolved
packages/service-library/src/servicelib/aiohttp/long_running_tasks/_routes.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the effort. Just a few suggestions/comments to take into consideration from my side.
packages/service-library/src/servicelib/long_running_tasks/_redis_store.py
Outdated
Show resolved
Hide resolved
packages/service-library/src/servicelib/long_running_tasks/task.py
Outdated
Show resolved
Hide resolved
packages/service-library/src/servicelib/long_running_tasks/task.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
Please check manually that the creation of projects does not get delayed anymore in the /results as described in the original gh issue.
packages/service-library/src/servicelib/long_running_tasks/_redis_store.py
Outdated
Show resolved
Hide resolved
packages/service-library/src/servicelib/long_running_tasks/task.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot
|
@Mergifyio queue |
🛑 Configuration not compatible with a branch protection settingThe branch protection setting |
…c-simcore-forked into pr-osparc-speedup-lrt-result
|



What do these changes do?
Users of
lrt_apino longer have to deal with waiting for the removal of a task. Once marked for removal, it no longer appears to them.The only side effect this causes is that
uniquelong running tasks, which are used by the dynamic-sidecar only cannot be restarted immediately. This should not have an impact, but I can easily address the issue if it appars.Related issue/s
get_task_resultPerformance #8340How to test
Dev-ops