🐛 Ensure consistent Celery task cancellation #8354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8354 +/- ##
==========================================
- Coverage 87.81% 87.66% -0.15%
==========================================
Files 1945 1529 -416
Lines 75557 63323 -12234
Branches 1313 686 -627
==========================================
- Hits 66348 55512 -10836
+ Misses 8813 7569 -1244
+ Partials 396 242 -154
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the Celery task cancellation mechanism by removing the dependency on AbortableTask and implementing a new cancellation approach based on task existence checking.
Key Changes:
- Replaced
AbortableTaskwith standard CeleryTaskacross the codebase - Implemented task cancellation through task removal rather than abortion
- Added
exists_taskmethod to check task existence for cancellation monitoring
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
packages/service-library/src/servicelib/celery/task_manager.py |
Added exists_task method to the TaskManager protocol |
packages/service-library/src/servicelib/celery/models.py |
Moved TASK_FINAL_STATES constant to module level and updated references |
packages/celery-library/tests/unit/test_tasks.py |
Updated test function signature to use standard Task instead of AbortableTask |
packages/celery-library/src/celery_library/task_manager.py |
Refactored cancellation logic to use task removal and added exists_task implementation |
packages/celery-library/src/celery_library/task.py |
Replaced AbortableTask usage with standard Task and updated cancellation monitoring |
🧪 CI InsightsHere's what we observed from your CI run for 5d0bca6. ✅ Passed Jobs With Interesting Signals
|
giancarloromeo
changed the title
giancarloromeo
commented
Sep 11, 2025
GitHK
approved these changes
Sep 11, 2025
giancarloromeo
changed the title
pcrespov
requested changes
Sep 11, 2025
services/api-server/src/simcore_service_api_server/api/routes/tasks.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/api/routes/tasks.py
Outdated
Show resolved
Hide resolved
pcrespov
reviewed
Sep 11, 2025
services/api-server/src/simcore_service_api_server/exceptions/handlers/__init__.py
Outdated
Show resolved
Hide resolved
pcrespov
reviewed
Sep 11, 2025
services/api-server/src/simcore_service_api_server/exceptions/handlers/__init__.py
Outdated
Show resolved
Hide resolved
|
This was referenced Sep 18, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR fixes the Celery task cancellation mechanism by removing the dependency on
AbortableTaskand implementing a new cancellation approach based on task existence checking.Key Changes:
AbortableTaskwith standard CeleryTaskacross the codebaseexists_taskmethod to check task existence for cancellation monitoringNote
We get rid of
AbortableTask, due to inconsistencies when used in combination oftask_track_started=Trueoption.See: celery/celery#2335
Related issue/s
How to test
Dev-ops
No changes