-
Notifications
You must be signed in to change notification settings - Fork 32
🎨 Added user identifiers to the UserAccountGetmodel
#8358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Added user identifiers to the UserAccountGetmodel
#8358
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8358 +/- ##
==========================================
+ Coverage 87.80% 89.62% +1.81%
==========================================
Files 1945 1550 -395
Lines 75545 63833 -11712
Branches 1312 556 -756
==========================================
- Hits 66333 57210 -9123
+ Misses 8817 6477 -2340
+ Partials 395 146 -249
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
UserAccountGetmodel
|
Thanks. In my User model, I already support |
…spov/osparc-simcore into is340/support-center-missing-fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comment
packages/models-library/src/models_library/api_schemas_webserver/users.py
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_webserver/users.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/users/_accounts_repository.py
Outdated
Show resolved
Hide resolved
|
@mergify queue |
🟠 Waiting for conditions to match
|
|



What do these changes do?
This pull request introduces new user-related fields to the user account API and its supporting data models.
API and Schema Enhancements
UserAccountGetoutput schema:user_id,user_name, anduser_primary_group_id, allowing API consumers to access these user details if an account was created.openapi.yamlto include the new fields (userId,userName,,userPrimaryGroupIDgroupId) in the user account response object and marked them as required, improving API documentation and validation. [1] [2]Data Model Changes
PrimaryGroupIDandStandardGroupIDingroups.py, and updated theGroupmodel to useGroupIDfor thegidfield, improving type safety and clarity for group identifiers. [1] [2]Backend Query and Service Updates
user_id,user_name, anduser_primary_group_idfields when merging pre-registered and registered user data. [1] [2] [3]Versioning
0.79.0to reflect the API changes. [1] [2] [3]Related issue/s
How to test
services/web/server/tests/unit/with_dbs/03/invitations/test_users_accounts_rest_registration.pyDev-ops
None