Skip to content

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented Sep 11, 2025

What do these changes do?

ReDoc

This pull request introduces new user-related fields to the user account API and its supporting data models.

API and Schema Enhancements

  • Added new fields to the UserAccountGet output schema: user_id, user_name, and user_primary_group_id, allowing API consumers to access these user details if an account was created.
  • Updated the OpenAPI specification in openapi.yaml to include the new fields (userId, userName, userPrimaryGroupID, groupId) in the user account response object and marked them as required, improving API documentation and validation. [1] [2]

Data Model Changes

  • Introduced new type aliases PrimaryGroupID and StandardGroupID in groups.py, and updated the Group model to use GroupID for the gid field, improving type safety and clarity for group identifiers. [1] [2]

Backend Query and Service Updates

  • Modified user account repository queries to select and expose user_id, user_name, and user_primary_group_id fields when merging pre-registered and registered user data. [1] [2] [3]
  • Updated account service logic to include the new user fields in API responses, ensuring consistent propagation of user identifiers and group information.

Versioning

  • Bumped the webserver service version to 0.79.0 to reflect the API changes. [1] [2] [3]

Related issue/s

How to test

  • Extended unit tests to verify the new fields in API responses: services/web/server/tests/unit/with_dbs/03/invitations/test_users_accounts_rest_registration.py

Dev-ops

None

@pcrespov pcrespov self-assigned this Sep 11, 2025
@pcrespov pcrespov added a:webserver webserver's codebase. Assigning the area is particularly useful for bugs a:api framework api, data schemas, labels Sep 11, 2025
@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

❌ Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.62%. Comparing base (3d6e600) to head (7a20787).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8358      +/-   ##
==========================================
+ Coverage   87.80%   89.62%   +1.81%     
==========================================
  Files        1945     1550     -395     
  Lines       75545    63833   -11712     
  Branches     1312      556     -756     
==========================================
- Hits        66333    57210    -9123     
+ Misses       8817     6477    -2340     
+ Partials      395      146     -249     
Flag Coverage Δ
integrationtests 64.03% <ø> (+0.02%) ⬆️
unittests 88.04% <90.90%> (+1.56%) ⬆️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 93.10% <100.00%> (+<0.01%) ⬆️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.19% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.03% <ø> (ø)
agent 93.53% <ø> (ø)
api_server 91.91% <ø> (ø)
autoscaling 95.77% <ø> (ø)
catalog 92.36% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 92.15% <ø> (+0.33%) ⬆️
datcore_adapter 97.94% <ø> (ø)
director 75.81% <ø> (ø)
director_v2 90.95% <ø> (+0.04%) ⬆️
dynamic_scheduler 96.27% <ø> (ø)
dynamic_sidecar 90.46% <ø> (ø)
efs_guardian 89.62% <ø> (ø)
invitations 91.44% <ø> (ø)
payments 92.61% <ø> (ø)
resource_usage_tracker 92.13% <ø> (ø)
storage 86.28% <ø> (-0.09%) ⬇️
webclient ∅ <ø> (∅)
webserver 87.96% <ø> (+0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d6e600...7a20787. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pcrespov pcrespov added this to the Cheops milestone Sep 11, 2025
@pcrespov pcrespov changed the title 🎨 Is340/support center missing fields 🎨 Added user identifiers to the UserAccountGetmodel Sep 11, 2025
@pcrespov pcrespov marked this pull request as ready for review September 11, 2025 09:27
@odeimaiz
Copy link
Member

Thanks.

In my User model, I already support gid and groupId, could you please rename the user_primary_group_id to one of those?

@mergify
Copy link
Contributor

mergify bot commented Sep 11, 2025

🧪 CI Insights

Here's what we observed from your CI run for 7a20787.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI unit-tests Base branch is broken, but retries were needed. Could be early signs of flakiness 👀 Broken 1 View View

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comment

@pcrespov pcrespov requested a review from GitHK September 11, 2025 14:32
@pcrespov pcrespov enabled auto-merge (squash) September 11, 2025 14:32
@pcrespov
Copy link
Member Author

@mergify queue

@pcrespov pcrespov added the 🤖-automerge marks PR as ready to be merged for Mergify label Sep 11, 2025
@mergify
Copy link
Contributor

mergify bot commented Sep 11, 2025

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
      • any of: [🛡 GitHub branch protection]
        • check-success = SonarCloud Code Analysis
        • check-neutral = SonarCloud Code Analysis
        • check-skipped = SonarCloud Code Analysis

@sonarqubecloud
Copy link

@pcrespov pcrespov merged commit 763be96 into ITISFoundation:master Sep 11, 2025
145 of 148 checks passed
@pcrespov pcrespov deleted the is340/support-center-missing-fields branch September 11, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:api framework api, data schemas, a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants