π Update API keys uniqueness constraint (ποΈ) #8363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giancarloromeo
added
the
a:webserver
giancarloromeo
changed the title
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8363 +/- ##
==========================================
- Coverage 87.42% 86.02% -1.40%
==========================================
Files 1945 1452 -493
Lines 75630 57518 -18112
Branches 1321 563 -758
==========================================
- Hits 66120 49482 -16638
+ Misses 9126 7902 -1224
+ Partials 384 134 -250
Continue to review full report in Codecov by Sentry.
π New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the uniqueness constraint for API keys in the database to include the product name, allowing users to have API keys with the same display name across different products.
- Updated the
api_keystable uniqueness constraint from(display_name, user_id)to(display_name, user_id, product_name) - Refactored test fixtures to use a factory pattern for better flexibility
- Added a new test to verify API keys with the same display name can be created for different products
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/postgres-database/src/simcore_postgres_database/models/api_keys.py |
Updated uniqueness constraint definition to include product_name |
packages/postgres-database/src/simcore_postgres_database/migration/versions/7e92447558e0_update_api_keys_uniqueness_constraint.py |
Database migration to update the constraint |
services/web/server/src/simcore_service_webserver/api_keys/_repository.py |
Updated conflict resolution to include product_name |
services/web/server/tests/unit/with_dbs/01/test_api_keys.py |
Refactored fixtures and added test for same display name across products |
giancarloromeo
requested review from
GitHK,
matusdrobuliak66,
pcrespov and
sanderegg
as code owners
β¦com:giancarloromeo/osparc-simcore into is8110/update-api-key-uniqueness-constraint
pcrespov
approved these changes
Sep 12, 2025
|
@Mergifyio queue |
giancarloromeo
added
the
π€-automerge
π Waiting for conditions to match
|
|
This was referenced Sep 18, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR updates the uniqueness constraint for API keys in the database to include the product name, allowing users to have API keys with the same display name across different products.
display_name, user_id) to (display_name, user_id, product_name)Related issue/s
How to test
Dev-ops
api_keystable.