Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Sep 18, 2025

What do these changes do?

  • moves most of logging facilities to the common library to allow usage of create_troubleshooting_log_kwargs also in the common-lib
  • adds some useful missing logs in the dv-2 computational scheduler to improve debugging sessions

Related issue/s

How to test

Dev-ops

@sanderegg sanderegg added this to the Cheops milestone Sep 18, 2025
@sanderegg sanderegg self-assigned this Sep 18, 2025
@sanderegg sanderegg added a:services-library issues on packages/service-libs a:director-v2 issue related with the director-v2 service a:computational clusters labels Sep 18, 2025
@codecov
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

❌ Patch coverage is 95.74468% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.69%. Comparing base (8896135) to head (277755b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8380      +/-   ##
==========================================
- Coverage   87.90%   87.69%   -0.22%     
==========================================
  Files        1951     1546     -405     
  Lines       75947    63857   -12090     
  Branches     1337      738     -599     
==========================================
- Hits        66763    55997   -10766     
+ Misses       8785     7609    -1176     
+ Partials      399      251     -148     
Flag Coverage Δ
integrationtests 63.95% <88.63%> (-0.05%) ⬇️
unittests 86.12% <95.74%> (-0.46%) ⬇️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 72.43% <78.57%> (-0.16%) ⬇️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 84.93% <ø> (ø)
agent 93.53% <100.00%> (ø)
api_server 91.96% <100.00%> (ø)
autoscaling 95.78% <100.00%> (ø)
catalog 92.36% <100.00%> (ø)
clusters_keeper 99.13% <100.00%> (ø)
dask_sidecar 91.81% <100.00%> (-0.57%) ⬇️
datcore_adapter 97.94% <100.00%> (ø)
director 75.81% <100.00%> (ø)
director_v2 90.97% <100.00%> (-0.01%) ⬇️
dynamic_scheduler 96.27% <100.00%> (ø)
dynamic_sidecar 90.46% <100.00%> (ø)
efs_guardian 89.62% <100.00%> (ø)
invitations 91.44% <100.00%> (ø)
payments 92.62% <100.00%> (ø)
resource_usage_tracker 92.24% <100.00%> (-0.06%) ⬇️
storage 86.45% <100.00%> (-0.09%) ⬇️
webclient ∅ <ø> (∅)
webserver 87.96% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8896135...277755b. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify
Copy link
Contributor

mergify bot commented Sep 18, 2025

🧪 CI Insights

Here's what we observed from your CI run for 277755b.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI unit-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logging.info("THX ;-)")

@sonarqubecloud
Copy link

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Contributor

@wvangeit wvangeit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@sanderegg sanderegg added the 🤖-automerge marks PR as ready to be merged for Mergify label Sep 18, 2025
@sanderegg
Copy link
Member Author

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Sep 18, 2025

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
      • any of: [🛡 GitHub branch protection]
        • check-success = SonarCloud Code Analysis
        • check-neutral = SonarCloud Code Analysis
        • check-skipped = SonarCloud Code Analysis
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

@sanderegg sanderegg merged commit 0a583a5 into ITISFoundation:master Sep 18, 2025
95 checks passed
@sanderegg sanderegg deleted the computational-backend/stability-improvements-step4 branch September 18, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:computational clusters a:director-v2 issue related with the director-v2 service a:services-library issues on packages/service-libs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants