♻️🐛🎨 Renaming and redesign of celery task metadata #8388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8388 +/- ##
==========================================
+ Coverage 87.65% 87.91% +0.25%
==========================================
Files 1832 1954 +122
Lines 71560 76107 +4547
Branches 1341 1342 +1
==========================================
+ Hits 62726 66907 +4181
- Misses 8433 8796 +363
- Partials 401 404 +3
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
|
@Mergifyio queue |
🟠 Waiting for conditions to match
|
This was referenced Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
celery-library) one can pass two different types of metadata:ExecutionMetadataandOwnerMetadata.ExecutionMetadataspecifies how and where a task should be executed and also additional properties associated with the behavior of the task (e.g.ephemeral).OwnerDatais a very flexible type of metadata which can be stored together with the task. The owner must specify who he is in theOwnerData(via theownerfield), but apart from that he can pass along other types of metadata as he pleases. Later he can filter his own tasks using a wildcard pattern.ExecutionMetadata(e.g. where the task should be executed) and hides that complexity for the api-server. On the other hand, when an osparc user requests the status for his task via the api-server, the api-server can now query the status directly via thecelery-library's task_manager. I.e. from the point of view of the api-server it is irrelevant where the task "lives" just to get the status. This works because the api-server'sOwnerMetadatais passed along in the storage rpc interface without modification.task_uuid, because that way, when the user requests the result of the task, the api-server could figure out what is the response model and validate it. This is required in order to adhere to the google api design guideline for long running task APIs (https://github.com/googleapis/googleapis/blob/master/google/longrunning/operations.proto#L150). With these design changes the endpoint'soperation_idcan easily be added to theOwnerMetadatato achieve exactly this.OwnerMetadatarequires anownerof a celery task to be specified means that owners will only see the tasks they own and no more. So this should work as a kind of security feature.Related issue/s
How to test
Dev-ops