Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Sep 18, 2025

What do these changes do?

This PR adds a 1hour timeout when pulling images instead of the default.
It is very unclear why this started to happen out of the blue with s4l-python-runner.

Related issue/s

How to test

Dev-ops

@sanderegg sanderegg added this to the Cheops milestone Sep 18, 2025
@sanderegg sanderegg self-assigned this Sep 18, 2025
@sanderegg sanderegg added the a:dask-service Any of the dask services: dask-scheduler/sidecar or worker label Sep 18, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a timeout issue with Docker image pulling in the dask-sidecar service by adding a 1-hour timeout configuration. The change addresses an issue where image pulls were timing out using the default timeout, particularly affecting the s4l-python-runner service.

  • Added a constant for 1-hour timeout configuration for Docker image pulling operations
  • Modified the pull_image function to use the extended timeout when pulling images

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sanderegg sanderegg requested a review from mguidon September 18, 2025 14:35
Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

Copy link
Contributor

@wvangeit wvangeit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sanderegg for the quick fix

@codecov
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.64%. Comparing base (1d59372) to head (9accf73).
⚠️ Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (1d59372) and HEAD (9accf73). Click for more details.

HEAD has 30 uploads less than BASE
Flag BASE (1d59372) HEAD (9accf73)
unittests 31 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #8389       +/-   ##
===========================================
- Coverage   87.69%   66.64%   -21.06%     
===========================================
  Files        1914      778     -1136     
  Lines       73783    35935    -37848     
  Branches     1336      175     -1161     
===========================================
- Hits        64703    23948    -40755     
- Misses       8680    11930     +3250     
+ Partials      400       57      -343     
Flag Coverage Δ
integrationtests 63.97% <ø> (-0.05%) ⬇️
unittests 92.38% <100.00%> (+6.06%) ⬆️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 76.69% <ø> (-8.30%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar 92.38% <100.00%> (+<0.01%) ⬆️
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.23% <ø> (-12.80%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 81.87% <ø> (-8.59%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 58.79% <ø> (-29.21%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d59372...9accf73. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify
Copy link
Contributor

mergify bot commented Sep 18, 2025

🧪 CI Insights

Here's what we observed from your CI run for 9accf73.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI integration-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View
unit-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

@sanderegg sanderegg force-pushed the dask-sidecar/pulling-large-images branch from 24b86e1 to 830c4f1 Compare September 18, 2025 15:00
@sanderegg sanderegg force-pushed the dask-sidecar/pulling-large-images branch from 830c4f1 to 9accf73 Compare September 18, 2025 15:07
@sonarqubecloud
Copy link

@sanderegg sanderegg merged commit e04c848 into ITISFoundation:master Sep 18, 2025
91 of 95 checks passed
@sanderegg sanderegg deleted the dask-sidecar/pulling-large-images branch September 18, 2025 15:30
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 19, 2025
65 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:dask-service Any of the dask services: dask-scheduler/sidecar or worker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: S4L python runner dies after exactly 5 min

3 participants