-
Notifications
You must be signed in to change notification settings - Fork 32
🐛Dask-sidecar: added a larger timeout when pulling images #8389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛Dask-sidecar: added a larger timeout when pulling images #8389
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a timeout issue with Docker image pulling in the dask-sidecar service by adding a 1-hour timeout configuration. The change addresses an issue where image pulls were timing out using the default timeout, particularly affecting the s4l-python-runner service.
- Added a constant for 1-hour timeout configuration for Docker image pulling operations
- Modified the
pull_imagefunction to use the extended timeout when pulling images
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
services/dask-sidecar/src/simcore_service_dask_sidecar/computational_sidecar/docker_utils.py
Show resolved
Hide resolved
mguidon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤞
wvangeit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sanderegg for the quick fix
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #8389 +/- ##
===========================================
- Coverage 87.69% 66.64% -21.06%
===========================================
Files 1914 778 -1136
Lines 73783 35935 -37848
Branches 1336 175 -1161
===========================================
- Hits 64703 23948 -40755
- Misses 8680 11930 +3250
+ Partials 400 57 -343
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
🧪 CI InsightsHere's what we observed from your CI run for 9accf73. ✅ Passed Jobs With Interesting Signals
|
24b86e1 to
830c4f1
Compare
830c4f1 to
9accf73
Compare
|



What do these changes do?
This PR adds a 1hour timeout when pulling images instead of the default.
It is very unclear why this started to happen out of the blue with s4l-python-runner.
Related issue/s
How to test
Dev-ops