-
Notifications
You must be signed in to change notification settings - Fork 32
🎨Computational backend: improvements step 6 #8397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨Computational backend: improvements step 6 #8397
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8397 +/- ##
===========================================
- Coverage 87.90% 68.62% -19.29%
===========================================
Files 1951 761 -1190
Lines 75951 35038 -40913
Branches 1336 175 -1161
===========================================
- Hits 66763 24044 -42719
- Misses 8788 10937 +2149
+ Partials 400 57 -343
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
f40b358 to
51a5010
Compare
🧪 CI InsightsHere's what we observed from your CI run for 2bde407. ✅ Passed Jobs With Interesting Signals
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the distributed.Variable mechanism from the Dask client module to address timeout issues that could lead to undefined states. The changes eliminate the use of distributed Variables for storing task futures and simplify the task processing pipeline by removing concurrent execution limits in favor of sequential processing.
- Removes distributed.Variable usage for storing and releasing task futures
- Replaces concurrent task processing with sequential execution to reduce scheduler load
- Removes unused imports and constants related to pipeline concurrency limits
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| dask_client.py | Removes distributed.Variable operations for task future storage and cleanup |
| _scheduler_dask.py | Converts concurrent task operations to sequential execution and adjusts concurrency limits |
| _scheduler_base.py | Replaces asyncio.gather with limited_gather for better concurrency control |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
services/director-v2/src/simcore_service_director_v2/modules/comp_scheduler/_scheduler_base.py
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/modules/comp_scheduler/_scheduler_base.py
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks



What do these changes do?
Related issue/s
How to test
Dev-ops