Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 19, 2025

What do these changes do?

This PR fixes and hides support buttons in the frontend depending on Support enabled or not.

Enabled:
Enabled

Disabled:
SupportDisabled

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz changed the title Fix/hide support buttons 🐛 [Frontend] Fix/hide support buttons Sep 19, 2025
@odeimaiz odeimaiz self-assigned this Sep 19, 2025
@odeimaiz odeimaiz requested a review from Copilot September 19, 2025 14:18
@odeimaiz odeimaiz added this to the Cheops milestone Sep 19, 2025
@odeimaiz odeimaiz added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Sep 19, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes and hides support buttons in the frontend, adding conditional visibility for support features based on group permissions. The changes refactor the BookACallIframe component to use properties for URL management and update the SupportCenter to conditionally show/hide support buttons.

  • Refactored BookACallIframe to use property-based URL management instead of static URL construction
  • Added conditional visibility to support buttons based on group support permissions
  • Improved code organization by extracting common stack page selection logic

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
BookACallIframe.js Refactored to use property-based URL management and improved constructor organization
SupportCenter.js Added conditional visibility for support buttons and refactored button state management

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@odeimaiz odeimaiz marked this pull request as ready for review September 19, 2025 14:18
@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2025

🧪 CI Insights

Here's what we observed from your CI run for 96b9a6e.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI integration-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View
unit-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

@sonarqubecloud
Copy link

@odeimaiz odeimaiz merged commit 16dafee into ITISFoundation:master Sep 19, 2025
57 of 58 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 24, 2025
65 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants