🐛 [Frontend] Fix workbench #8402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
bug
🧪 CI InsightsHere's what we observed from your CI run for 08961c6. ✅ Passed Jobs With Interesting Signals
|
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a workbench interaction bug that was introduced in PR #8393 by removing a decorator property and corrects button text/icons in support pages.
- Removes the
decorator: "rounded"property from NodeUI configuration that was causing workbench interaction issues - Updates "Book a Call 3rd" button text to "Book a Call" and changes icon from phone to flask in support pages
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| NodeUI.js | Removes decorator property to fix workbench interaction bug |
| HomePage.js | Updates button text and icon for book-a-call functionality |
| ConversationsPage.js | Updates button text and icon for book-a-call functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
services/static-webserver/client/source/class/osparc/support/HomePage.js
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/support/ConversationsPage.js
Show resolved
Hide resolved
odeimaiz
requested review from
GitHK,
bisgaard-itis,
giancarloromeo,
matusdrobuliak66,
pcrespov and
sanderegg
giancarloromeo
approved these changes
Sep 22, 2025
matusdrobuliak66
approved these changes
Sep 22, 2025
GitHK
approved these changes
Sep 22, 2025
pcrespov
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
A bug was introduced in #8393, not letting users interact with the workbench. This PR fixes it.
Related issue/s
How to test
Dev-ops