♻️🎨 [Frontend] Refactor conversations #8404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 CI InsightsHere's what we observed from your CI run for d19dc28. ✅ Passed Jobs With Interesting Signals
|
odeimaiz
added
t:enhancement
There was a problem hiding this comment.
Pull Request Overview
This PR refactors conversation components to achieve uniform chat styling and behavior across support and study conversations by creating a common base class and consolidating shared functionality.
- Extracts common conversation logic into a reusable base class (
osparc.conversation.Conversation) - Replaces inline CSS styling with a centralized "circled" decorator for consistent UI appearance
- Separates conversation display from page management by introducing
ConversationPage
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| osparc/conversation/Conversation.js | New base class containing shared conversation functionality |
| osparc/support/Conversation.js | Refactored to extend the new base class, removing duplicated code |
| osparc/study/Conversation.js | Simplified to extend base class and focus on study-specific behavior |
| osparc/study/ConversationPage.js | New component separating page management from conversation display |
| osparc/theme/Decoration.js | Added "circled" decorator for consistent styling |
| Multiple UI files | Replaced inline border-radius styling with "circled" decorator |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
services/static-webserver/client/source/class/osparc/study/ConversationPage.js
Outdated
Show resolved
Hide resolved
…versationPage.js Co-authored-by: Copilot <[email protected]>
odeimaiz
changed the title
|
odeimaiz
requested review from
GitHK,
bisgaard-itis,
giancarloromeo,
matusdrobuliak66,
pcrespov and
sanderegg
matusdrobuliak66
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR refactors conversation components to achieve uniform chat styling and behavior across Support and Project Conversations by creating a common base class and consolidating shared functionality.
Related issue/s
How to test
Dev-ops