-
Notifications
You must be signed in to change notification settings - Fork 32
🎨 TaskID -> TaskKey
#8409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bisgaard-itis
merged 88 commits into
ITISFoundation:master
from
bisgaard-itis:improve-celery-task-error-messages-and-improve-taskid-name
Oct 3, 2025
Merged
🎨 TaskID -> TaskKey
#8409
bisgaard-itis
merged 88 commits into
ITISFoundation:master
from
bisgaard-itis:improve-celery-task-error-messages-and-improve-taskid-name
Oct 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giancarloromeo
approved these changes
Sep 26, 2025
GitHK
approved these changes
Sep 26, 2025
sanderegg
approved these changes
Sep 26, 2025
matusdrobuliak66
approved these changes
Sep 26, 2025
|
@Mergifyio queue |
🟠 Waiting for conditions to match
|
|
bisgaard-itis
added a commit
to pcrespov/osparc-simcore
that referenced
this pull request
Oct 3, 2025
This was referenced Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



What do these changes do?
celery-libraryI have been confused by the difference between theTaskIDand theTaskUUID. In fact theTaskUUIDis the id of the task. TheTaskIDon the other hand is the "key" associated with that task in Redis (which is called the id inside Celery). To make this less confusion for osparc-simcore devs I here changeTaskIDtoTaskKey. Data can be retrieved from theTaskKeyusing theOwnerMetadataclass.TaskKeyis mapped to the id of the task inside Celery I don't find so confusing because we don't work with Celery directly - we work with ourcelery-library.TaskKeydirectly in the error message (as this could contain confidential data.Related issue/s
How to test
Dev-ops