Skip to content

🎨 TaskID -> TaskKey #8409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 88 commits into from
Oct 3, 2025
Merged

🎨 TaskID -> TaskKey #8409

merged 88 commits into from
Oct 3, 2025

Conversation

@bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Sep 23, 2025 •
edited
Loading

What do these changes do?

  • When working with our wonderful celery-library I have been confused by the difference between the TaskID and the TaskUUID. In fact the TaskUUID is the id of the task. The TaskID on the other hand is the "key" associated with that task in Redis (which is called the id inside Celery). To make this less confusion for osparc-simcore devs I here change TaskID to TaskKey. Data can be retrieved from the TaskKey using the OwnerMetadata class.
  • The fact that TaskKey is mapped to the id of the task inside Celery I don't find so confusing because we don't work with Celery directly - we work with our celery-library.
  • I also fix the handing of celery-library errors in the api-server to not expose the TaskKey directly in the error message (as this could contain confidential data.

Related issue/s

How to test

Dev-ops

@bisgaard-itis
add task_owner as required field in TaskFilter
87e855c
@bisgaard-itis
client_name -> TaskOwner
4462b0e
@bisgaard-itis
make AsyncJobFilter minimal
51ef580
@bisgaard-itis
improve naming
26abc99
@bisgaard-itis
task_owner -> owner
d2cf678
@bisgaard-itis
TaskFilter -> OwnerMetadata
87c63ef
@bisgaard-itis
further fixes to OwnerMetadata
a66d944
@bisgaard-itis
minor fix
052aa3f
@bisgaard-itis
Merge branch 'master' into 8387-fix-log-endpoint-in-api-server
b716c64
@bisgaard-itis
cleanup
e3033e5
@bisgaard-itis
cleanup task submit in webserver
07531d4
@bisgaard-itis
test fixes
e0ed541
@bisgaard-itis
get rid of AsyncJobFilter
a8e106e
@bisgaard-itis
small fix in api-server
e9aa9ba
@bisgaard-itis
fix tests in celery-library
d690ddd
@bisgaard-itis
fix webserver
e57f34e
@bisgaard-itis
Merge branch 'master' into 8387-fix-log-endpoint-in-api-server
301fe56
@bisgaard-itis
fix
2b9765f
@bisgaard-itis
test fix in api-server
6314cdf
@bisgaard-itis
fix in mocks
b59d1ee
@bisgaard-itis
several test fixes
c29ef31
@bisgaard-itis
yet another minor fix
c5042d5
@bisgaard-itis
fix
0f09f84
@bisgaard-itis
Merge branch 'master' into 8387-fix-log-endpoint-in-api-server
2451056
@bisgaard-itis
make wildcard a basemodel
5f220b8
@bisgaard-itis
test fixes
db10040
@bisgaard-itis
test fix
615891e
@bisgaard-itis
several fixes
24ef2be
@bisgaard-itis
improve validation from task_id
7e94b08
@bisgaard-itis
Merge branch 'master' into 8387-fix-log-endpoint-in-api-server
c25f45d
giancarloromeo
giancarloromeo reviewed Sep 26, 2025
View reviewed changes
@bisgaard-itis bisgaard-itis enabled auto-merge (squash) September 29, 2025 13:57
@bisgaard-itis
Copy link
Contributor Author

bisgaard-itis commented Sep 29, 2025

@Mergifyio queue

@bisgaard-itis bisgaard-itis added the 🤖-automerge marks PR as ready to be merged for Mergify label Sep 29, 2025
@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2025 •
edited
Loading

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
      • any of: [🛡 GitHub branch protection]
        • check-success = SonarCloud Code Analysis
        • check-neutral = SonarCloud Code Analysis
        • check-skipped = SonarCloud Code Analysis

@bisgaard-itis bisgaard-itis disabled auto-merge October 2, 2025 09:34
@bisgaard-itis bisgaard-itis added 🤖-automerge marks PR as ready to be merged for Mergify and removed 🤖-automerge marks PR as ready to be merged for Mergify labels Oct 2, 2025
@bisgaard-itis bisgaard-itis enabled auto-merge (squash) October 3, 2025 10:11
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@bisgaard-itis bisgaard-itis merged commit 5a86ddb into ITISFoundation:master Oct 3, 2025
146 of 148 checks passed
@bisgaard-itis bisgaard-itis deleted the improve-celery-task-error-messages-and-improve-taskid-name branch October 3, 2025 11:24
bisgaard-itis added a commit to pcrespov/osparc-simcore that referenced this pull request Oct 3, 2025
@bisgaard-itis
🎨 TaskID -> TaskKey (ITISFoundation#8409)
c95d0f3
This was referenced Oct 28, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg sanderegg approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

Assignees

@bisgaard-itis bisgaard-itis

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:celery-library

Projects

None yet

Milestone

Cheops

Development

Successfully merging this pull request may close these issues.

6 participants

@bisgaard-itis @giancarloromeo @GitHK @pcrespov @sanderegg @matusdrobuliak66