-
Notifications
You must be signed in to change notification settings - Fork 32
🐛 Add internal scheduler UI in dynamic-scheduler #8410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Add internal scheduler UI in dynamic-scheduler #8410
Conversation
…-dy-scheduler-part3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a placeholder UI for the internal scheduler in the dynamic-scheduler service. It introduces conditional rendering based on the DYNAMIC_SCHEDULER_USE_INTERNAL_SCHEDULER setting to display either the external or internal scheduler UI.
- Added new internal scheduler routes with a placeholder UI page
- Refactored test configuration to properly reset NiceGUI app state between tests
- Fixed model schema access to use the correct Pydantic v2 method
Reviewed Changes
Copilot reviewed 9 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/simcore_service_dynamic_scheduler/api/frontend/routes_internal_scheduler/__init__.py |
Creates router module for internal scheduler routes |
src/simcore_service_dynamic_scheduler/api/frontend/routes_internal_scheduler/_index.py |
Implements placeholder UI page for internal scheduler |
src/simcore_service_dynamic_scheduler/api/frontend/_setup.py |
Adds conditional router inclusion based on scheduler type setting |
src/simcore_service_dynamic_scheduler/api/frontend/routes_external_scheduler/_service.py |
Fixes import order for rabbitmq module |
tests/unit/api_frontend/conftest.py |
Refactors test setup with proper NiceGUI reset and scheduler configuration |
tests/unit/api_frontend/helpers.py |
Updates model schema access to use Pydantic v2 syntax |
tests/unit/api_frontend/_routes_internal_scheduler/conftest.py |
Configures tests to use internal scheduler |
tests/unit/api_frontend/_routes_internal_scheduler/test__index_.py |
Tests the internal scheduler placeholder UI |
tests/unit/api_frontend/routes_external_scheduler/conftest.py |
Configures tests to use external scheduler with service mocks |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #8410 +/- ##
===========================================
- Coverage 87.90% 67.09% -20.82%
===========================================
Files 1951 816 -1135
Lines 76035 36404 -39631
Branches 1341 175 -1166
===========================================
- Hits 66837 24424 -42413
- Misses 8797 11923 +3126
+ Partials 401 57 -344
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
...duler/src/simcore_service_dynamic_scheduler/api/frontend/routes_external_scheduler/_index.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
...rc/simcore_service_dynamic_scheduler/api/frontend/routes_external_scheduler/_render_utils.py
Show resolved
Hide resolved
services/dynamic-scheduler/tests/unit/api_frontend/_routes_internal_scheduler/test__index_.py
Outdated
Show resolved
Hide resolved
services/dynamic-scheduler/tests/unit/api_frontend/routes_external_scheduler/test__index.py
Show resolved
Hide resolved
services/dynamic-scheduler/tests/unit/api_frontend/routes_external_scheduler/test__service.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
th
…-dy-scheduler-part3
|



What do these changes do?
Related issue/s
Added placeholder UI which is displayed when
DYNAMIC_SCHEDULER_USE_INTERNAL_SCHEDULERis True.Refactored and fixed tests to accomodate both UIs. The NiceGUI application was not being reset properly between tests.
How to test
Dev-ops