Skip to content

Conversation

@sanderegg
Copy link
Member

What do these changes do?

#8401 introduced a FAIR queued semaphore.
Tests running in master CI revealed a race condition on the initialization phase of the semaphore. This PR fixes this definitely.

Related issue/s

How to test

Dev-ops

@sanderegg sanderegg added this to the Cheops milestone Sep 23, 2025
@sanderegg sanderegg self-assigned this Sep 23, 2025
@sanderegg sanderegg requested a review from pcrespov as a code owner September 23, 2025 22:02
@sanderegg sanderegg added the a:services-library issues on packages/service-libs label Sep 23, 2025
@codecov
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.78%. Comparing base (a210b2d) to head (d1b5f03).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8411      +/-   ##
==========================================
- Coverage   89.57%   87.78%   -1.80%     
==========================================
  Files        1750     1523     -227     
  Lines       68604    63332    -5272     
  Branches      837      679     -158     
==========================================
- Hits        61450    55593    -5857     
- Misses       6931     7503     +572     
- Partials      223      236      +13     
Flag Coverage Δ
integrationtests 63.93% <ø> (-0.09%) ⬇️
unittests 86.19% <100.00%> (-1.92%) ⬇️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 72.56% <100.00%> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 84.99% <ø> (ø)
agent 93.53% <ø> (ø)
api_server 91.96% <ø> (ø)
autoscaling 95.74% <ø> (ø)
catalog 92.36% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 92.38% <ø> (ø)
datcore_adapter 97.94% <ø> (ø)
director 75.81% <ø> (ø)
director_v2 90.88% <ø> (-0.09%) ⬇️
dynamic_scheduler 96.27% <ø> (ø)
dynamic_sidecar 90.43% <ø> (ø)
efs_guardian 89.62% <ø> (ø)
invitations 91.44% <ø> (ø)
payments 92.62% <ø> (ø)
resource_usage_tracker 91.71% <ø> (-0.54%) ⬇️
storage 86.53% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 88.02% <ø> (+0.04%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a210b2d...d1b5f03. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanderegg sanderegg merged commit fba8218 into ITISFoundation:master Sep 23, 2025
2 checks passed
@sanderegg sanderegg deleted the semaphore/fix-flaky-test branch September 23, 2025 22:13
@sonarqubecloud
Copy link

@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2025

🧪 CI Insights

Here's what we observed from your CI run for d1b5f03.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI unit-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 24, 2025
65 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:services-library issues on packages/service-libs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant