🎨 [Frontend] Create Function: Do not allow registering functions without exposing 1 input AND 1 output #8412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
changed the title
odeimaiz
changed the title
odeimaiz
added
t:enhancement
…ore into enh/function-checks
There was a problem hiding this comment.
Pull Request Overview
Refactors the function creation validation logic to require both inputs AND outputs instead of inputs OR outputs, with improved UI feedback for disabled states.
- Moved
isPotentialFunctionfromosparc.study.Utilstoosparc.study.CreateFunctionwith updated logic requiring both parameters and probes - Added validation in
__createFunctionto check for exposed inputs and outputs before proceeding - Created reusable tooltip utility for disabled widgets to improve user experience
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/utils/Utils.js | Added toolTipTextOnDisabledWidget utility function for consistent tooltip handling |
| services/static-webserver/client/source/class/osparc/study/Utils.js | Removed isPotentialFunction method (moved to CreateFunction class) |
| services/static-webserver/client/source/class/osparc/study/CreateFunction.js | Added static methods including updated isPotentialFunction logic and validation functions |
| services/static-webserver/client/source/class/osparc/form/renderer/PropForm.js | Refactored to use new tooltip utility function |
| services/static-webserver/client/source/class/osparc/dashboard/ResourceDetails.js | Updated to use new isPotentialFunction location and added disabled state handling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
services/static-webserver/client/source/class/osparc/study/CreateFunction.js
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/study/CreateFunction.js
Show resolved
Hide resolved
odeimaiz
requested review from
GitHK,
JavierGOrdonnez,
alexpargon,
bisgaard-itis,
giancarloromeo,
matusdrobuliak66,
pcrespov,
sanderegg and
wvangeit
wvangeit
approved these changes
Sep 24, 2025
🧪 CI InsightsHere's what we observed from your CI run for 662401f. 🟢 All jobs passed!But CI Insights is watching 👀 |
|
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
JavierGOrdonnez
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR implements Function Creation validation logic to require both inputs AND outputs to be exposed. It also updates the
isPotentialFunctionto expect both, input(s) AND output(s). If the project is not "Funcionable" instead of hiding the button, it's now disabled and it shows a tooltip explaining why it's disabled.Related issue/s
How to test
Dev-ops