Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 24, 2025

What do these changes do?

So far, the modified flag was used to color the output port and links. This flag was used together with a hasOutputs variable not in consistent way. This PR makes more consistent and exposes the modified flag in a more intuitive way:

  • Show star (*) on nodeUI if the node is marked as modified: "Needs to run to update the outputs"
  • The output port and outbound link are marked as out-of-date if the node is modified and hasOutputs (outputs exist). Both the port and link support more states: "not-available", "busy", "up-to-date", "out-of-date"

Bonus:

  • Clicking on an input/output port opens the service catalog and connects the new node

Modified

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz self-assigned this Sep 24, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Sep 24, 2025
@odeimaiz odeimaiz added this to the Cheops milestone Sep 24, 2025
@mergify
Copy link
Contributor

mergify bot commented Sep 24, 2025

🧪 CI Insights

Here's what we observed from your CI run for 9d67db2.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI unit-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

@odeimaiz odeimaiz marked this pull request as ready for review September 24, 2025 13:29
@odeimaiz odeimaiz requested a review from Copilot September 24, 2025 13:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements consistent handling of the modified state in the frontend workbench by showing a star (*) when nodes are modified and need to run to update outputs. It also adds functionality to open the service catalog when clicking on input/output ports.

  • Show modified star indicator on nodes that need to run
  • Update edge coloring to use output state instead of modified state
  • Add click handlers to ports for opening service catalog with context

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
osparc/workbench/NodeUI.js Adds modified star indicator and port click handlers
osparc/workbench/EdgeUI.js Updates edge coloring logic to use output state
osparc/workbench/WorkbenchUI.js Refactors service catalog opening and adds validation
osparc/workbench/ServiceCatalog.js Adds validation method for opening service catalog
osparc/data/model/NodeStatus.js Simplifies modified state handling and output evaluation
osparc/service/StatusUI.js Adds color mapping for not-available state
osparc/theme/*.js Updates color definitions for workbench edges
osparc/wrapper/Svg.js Updates edge color references
osparc/widget/PersistentIframe.js Code cleanup for message handling
osparc/navigation/BreadcrumbsSlideshow.js Variable naming improvement
osparc/desktop/SlideshowView.js Adds validation before opening service catalog

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sonarqubecloud
Copy link

@odeimaiz odeimaiz enabled auto-merge (squash) September 24, 2025 14:01
@odeimaiz odeimaiz merged commit 9a67845 into ITISFoundation:master Sep 24, 2025
58 checks passed
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! You could even animate the arrow coloring!

@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 24, 2025
65 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants