-
Notifications
You must be signed in to change notification settings - Fork 32
🐛🎨 [Frontend] Consistent modified
#8413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛🎨 [Frontend] Consistent modified
#8413
Conversation
…ore into enh/function-checks
…simcore into fix/consistent-modified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements consistent handling of the modified state in the frontend workbench by showing a star (*) when nodes are modified and need to run to update outputs. It also adds functionality to open the service catalog when clicking on input/output ports.
- Show modified star indicator on nodes that need to run
- Update edge coloring to use output state instead of modified state
- Add click handlers to ports for opening service catalog with context
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| osparc/workbench/NodeUI.js | Adds modified star indicator and port click handlers |
| osparc/workbench/EdgeUI.js | Updates edge coloring logic to use output state |
| osparc/workbench/WorkbenchUI.js | Refactors service catalog opening and adds validation |
| osparc/workbench/ServiceCatalog.js | Adds validation method for opening service catalog |
| osparc/data/model/NodeStatus.js | Simplifies modified state handling and output evaluation |
| osparc/service/StatusUI.js | Adds color mapping for not-available state |
| osparc/theme/*.js | Updates color definitions for workbench edges |
| osparc/wrapper/Svg.js | Updates edge color references |
| osparc/widget/PersistentIframe.js | Code cleanup for message handling |
| osparc/navigation/BreadcrumbsSlideshow.js | Variable naming improvement |
| osparc/desktop/SlideshowView.js | Adds validation before opening service catalog |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
services/static-webserver/client/source/class/osparc/workbench/NodeUI.js
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/workbench/ServiceCatalog.js
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/data/model/NodeStatus.js
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! You could even animate the arrow coloring!



What do these changes do?
So far, the modified flag was used to color the output port and links. This flag was used together with a
hasOutputsvariable not in consistent way. This PR makes more consistent and exposes themodifiedflag in a more intuitive way:modified: "Needs to run to update the outputs"out-of-dateif the node ismodifiedandhasOutputs(outputs exist). Both the port and link support more states:"not-available", "busy", "up-to-date", "out-of-date"Bonus:
Related issue/s
How to test
Dev-ops