Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 24, 2025

What do these changes do?

reported by @ahalder2

This PR adds character limits to conversation titles and message content in the frontend. The main purpose is to enforce a maximum length of 50 characters for conversation titles and 4096 characters for message content.

Bonus

  • Refactored the Renamer widget to use a property-based approach for character limits

Limited to 10 for the demo:
LimitTitle

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz self-assigned this Sep 24, 2025
@odeimaiz odeimaiz added this to the Cheops milestone Sep 24, 2025
@odeimaiz odeimaiz added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Sep 24, 2025
@odeimaiz odeimaiz requested a review from Copilot September 24, 2025 14:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds character limits to conversation titles and message content in the frontend. The main purpose is to enforce a maximum length of 50 characters for conversation titles and 4096 characters for message content.

  • Refactored the Renamer widget to use a property-based approach for character limits
  • Added constants for maximum title and content lengths in the Conversation model
  • Applied character limits to conversation renaming functionality and message input

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
osparc/widget/Renamer.js Refactored to use child controls and added maxChars property with subtitle display
osparc/support/ConversationPage.js Applied character limit to conversation renaming
osparc/study/ConversationPage.js Applied character limit to conversation renaming
osparc/data/model/Conversation.js Added constants for max title/content length and improved error handling
osparc/conversation/AddMessage.js Applied character limit to message input field

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@odeimaiz odeimaiz enabled auto-merge (squash) September 24, 2025 14:52
@sonarqubecloud
Copy link

@mergify
Copy link
Contributor

mergify bot commented Sep 24, 2025

🧪 CI Insights

Here's what we observed from your CI run for 5e679ab.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI unit-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

@odeimaiz odeimaiz merged commit 1efd09c into ITISFoundation:master Sep 24, 2025
58 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 24, 2025
65 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants