Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 25, 2025

What do these changes do?

requested by @calys

This PR enhances the Book a Call functionality by introducing a topic selection step before initiating calls. The selected topic and extra info will go in the first message of the conversation, bringing this context into the fogbugz issue.

BookACallTopic

Bonus

  • Standardize list styling across the application using a new "listing" appearance and refactors styling to use more consistent color schemes

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz self-assigned this Sep 25, 2025
@odeimaiz odeimaiz added this to the Cheops milestone Sep 25, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Sep 25, 2025
@mergify
Copy link
Contributor

mergify bot commented Sep 25, 2025

🧪 CI Insights

Here's what we observed from your CI run for b3bea5c.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI system-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View
unit-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

@odeimaiz odeimaiz requested a review from Copilot September 26, 2025 09:40
@odeimaiz odeimaiz marked this pull request as ready for review September 26, 2025 09:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the Book a Call functionality by introducing a topic selection step before initiating calls. It standardizes list styling across the application using a new "listing" appearance and refactors styling to use more consistent color schemes.

  • Introduces a new BookACallTopicSelector component requiring users to select a call topic first
  • Standardizes list appearances across the application using a new "listing" style
  • Refactors color themes and consolidates duplicate topic definitions

Reviewed Changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
BookACallTopicSelector.js New component for selecting call topics with radio button options
ConversationPage.js Integrates topic selector into call booking flow
Conversation.js Handles book-a-call info and project sharing logic
VipMarket.js Updates list styling to use new "listing" appearance
Appearance.js Defines new "listing" appearance with consistent styling
Utils.js Centralizes S4L topics and book-a-call enablement logic
RequestAccount.js Uses centralized S4L topics from Utils
Multiple list components Standardize styling using "listing" appearance and cursor settings

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@sonarqubecloud
Copy link

@odeimaiz odeimaiz added the 🤖-automerge marks PR as ready to be merged for Mergify label Sep 26, 2025
@odeimaiz
Copy link
Member Author

odeimaiz commented Sep 26, 2025

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2025

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
      • any of: [🛡 GitHub branch protection]
        • check-success = SonarCloud Code Analysis
        • check-neutral = SonarCloud Code Analysis
        • check-skipped = SonarCloud Code Analysis

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz merged commit 3941b09 into ITISFoundation:master Sep 26, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants