♻️ Refactor: migrate more aiohttp app keys to type-safe web.AppKey

[pcrespov]

What do these changes do?

Follows up on PR #8405
This continues the migration of aiohttp app keys from plain strings to type-safe web.AppKey.

SEE https://docs.aiohttp.org/en/stable/web_reference.html#aiohttp.web.AppKey

Changes

Before

from typing import Final

APP_MY_KEY: Final[str] = f"{__name__}.APP_MY_KEY"
app[APP_MY_KEY] = value
data = request.app[APP_MY_KEY]

After

from typing import Final
from aiohttp import web

CONSTNAME_APPKEY: Final = web.AppKey("CONSTNAME", SomeSpecificType)
app[CONSTNAME_APPKEY] = value
data = request.app[CONSTNAME_APPKEY]  # type-safe
# no need to cast anymore — mypy infers the correct type

NOTE: this can be done using refactor-aiohttp-appkey.prompt.md

---

Additions

• Introduced application_keys.py (or $(domain)/_application_keys.py)
• Added refactor-aiohttp-appkey.prompt.md to streamline future refactors

Related issue/s

• Follows up 🎨 Updates all aiohttp state application keys from string-based keys to type-safe web.AppKey instances #8405
• resolves further Address aiohttp NotAppKeyWarning: It is recommended to use web.AppKey instances for keys #7734

How to test

in place

Dev-ops

None

[codecov]

Codecov Report

❌ Patch coverage is 94.76923% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.85%. Comparing base (1dbb64b) to head (2d612cb).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8424      +/-   ##
==========================================
- Coverage   89.01%   87.85%   -1.17%     
==========================================
  Files        1753     1957     +204     
  Lines       68638    76126    +7488     
  Branches      837     1342     +505     
==========================================
+ Hits        61098    66877    +5779     
- Misses       7331     8845    +1514     
- Partials      209      404     +195     

Flag	Coverage Δ
integrationtests	64.10% <72.93%> (+0.73%)	⬆️
unittests	86.51% <94.15%> (-1.53%)	⬇️

Components	Coverage Δ
pkg_aws_library	93.59% <ø> (ø)
pkg_celery_library	83.41% <ø> (ø)
pkg_dask_task_models_library	79.33% <ø> (ø)
pkg_models_library	93.08% <ø> (ø)
pkg_notifications_library	85.20% <ø> (ø)
pkg_postgres_database	87.95% <ø> (ø)
pkg_service_integration	70.19% <ø> (ø)
pkg_service_library	72.55% <59.09%> (∅)
pkg_settings_library	90.19% <ø> (ø)
pkg_simcore_sdk	84.93% <ø> (+19.65%)	⬆️
agent	93.53% <ø> (ø)
api_server	91.94% <ø> (ø)
autoscaling	95.74% <ø> (ø)
catalog	92.36% <ø> (ø)
clusters_keeper	99.13% <ø> (ø)
dask_sidecar	91.82% <ø> (-0.56%)	⬇️
datcore_adapter	97.94% <ø> (ø)
director	75.81% <ø> (ø)
director_v2	90.84% <ø> (-0.10%)	⬇️
dynamic_scheduler	96.30% <ø> (ø)
dynamic_sidecar	90.43% <ø> (ø)
efs_guardian	89.62% <ø> (ø)
invitations	91.44% <ø> (ø)
payments	92.62% <ø> (ø)
resource_usage_tracker	92.18% <ø> (+0.05%)	⬆️
storage	86.65% <ø> (ø)
webclient	∅ <ø> (∅)
webserver	87.86% <97.35%> (+0.08%)	⬆️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dbb64b...2d612cb. Read the comment docs.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mergify]

🧪 CI Insights

Here's what we observed from your CI run for 2d612cb.

✅ Passed Jobs With Interesting Signals

Pipeline	Job	Signal	Health on master	Retries	🔍 CI Insights	📄 Logs
CI	integration-tests	Base branch is broken, but the job passed. Looks like this might be a real fix 💪		0	View	View
	system-tests	Base branch is broken, but the job passed. Looks like this might be a real fix 💪		0	View	View
	unit-tests	Base branch is broken, but retries were needed. Could be early signs of flakiness 👀		1	View	View

[Copilot]

Pull Request Overview

This pull request continues the migration of aiohttp app keys from plain string constants to type-safe web.AppKey objects, building on the work started in PR #8405. This refactoring improves type safety and eliminates the need for manual type casting when accessing application state.

Key changes include:

• Converting string-based app key constants to web.AppKey objects with proper typing
• Updating all usage patterns throughout the codebase to use the new type-safe keys
• Creating centralized application_keys.py files to organize these definitions

Reviewed Changes

Copilot reviewed 112 out of 113 changed files in this pull request and generated 3 comments.

File	Description
services/web/server/src/simcore_service_webserver/application_keys.py	New centralized file defining type-safe application keys
Various plugin and service files	Updated to import and use new APP_SETTINGS_APPKEY instead of APP_SETTINGS_KEY
Multiple test files	Updated to use new type-safe app keys for testing
Various constant and key definition files	Migrated string-based keys to web.AppKey objects

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[pcrespov]

@mergify queue

[mergify]

queue

🛑 Configuration not compatible with a branch protection setting

The branch protection setting Require branches to be up to date before merging is not compatible with max_parallel_checks>1, queue_conditions != merge_conditions and must be unset.

[sanderegg]

thanks

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud