- 
                Notifications
    
You must be signed in to change notification settings  - Fork 32
 
✨ Add Celery task manager to Web Server ⚠️ #8436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add Celery task manager to Web Server ⚠️ #8436
Conversation
          Codecov Report❌ Patch coverage is  Additional details and impacted files@@            Coverage Diff             @@
##           master    #8436      +/-   ##
==========================================
- Coverage   87.64%   87.61%   -0.04%     
==========================================
  Files        1983     1990       +7     
  Lines       77292    77403     +111     
  Branches     1333     1333              
==========================================
+ Hits        67746    67820      +74     
- Misses       9147     9184      +37     
  Partials      399      399              
 
 Continue to review full report in Codecov by Sentry. 
 🚀 New features to boost your workflow:
  | 
    
…-task-manager-to-webserver
…com:giancarloromeo/osparc-simcore into is8102/add-celery-task-manager-to-webserver
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just wondering why the stream is still present here
        
          
                services/web/server/src/simcore_service_webserver/api/v0/openapi.yaml
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                services/web/server/tests/unit/with_dbs/01/tasks/test_tasks_rest_controller.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx! (and sorry for the delay in the review)
        
          
                services/web/server/tests/unit/with_dbs/01/tasks/test_tasks_rest_controller.py
          
            Show resolved
            Hide resolved
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…-task-manager-to-webserver
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
          
 | 
    
| 
           Thanks @pcrespov  | 
    



What do these changes do?
This PR adds Celery task manager functionality to the Web Server, enabling asynchronous task management and streaming capabilities. The changes refactor the existing task handling system from RabbitMQ-based async jobs to a Celery-based task manager with Redis backend.
Key Changes:
NOTE
This PR is needed for #8102 issue, allowing Streaming of events from running tasks.
Related issue/s
How to test
Dev-ops
WEBSERVER_CELERYenv var, must be enabled only onweb-serverand not inwb-*