Skip to content

Conversation

@bisgaard-itis
Copy link
Contributor

What do these changes do?

  • Increase the function rpc timeouts to 30sec. See the issue below for the motivation for doing so.

Related issue/s

How to test

Dev-ops

@bisgaard-itis bisgaard-itis self-assigned this Oct 1, 2025
@bisgaard-itis bisgaard-itis added this to the Cheops milestone Oct 1, 2025
@bisgaard-itis bisgaard-itis marked this pull request as ready for review October 1, 2025 12:04
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 1, 2025

Copy link
Contributor

@wvangeit wvangeit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@codecov
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.81%. Comparing base (2eb46b7) to head (1209bdd).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8440      +/-   ##
==========================================
- Coverage   87.96%   87.81%   -0.16%     
==========================================
  Files        1922     1548     -374     
  Lines       74814    64531   -10283     
  Branches     1342      680     -662     
==========================================
- Hits        65813    56668    -9145     
+ Misses       8597     7624     -973     
+ Partials      404      239     -165     
Flag Coverage Δ
integrationtests 64.17% <ø> (+0.05%) ⬆️
unittests 86.24% <0.00%> (-0.38%) ⬇️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 72.54% <0.00%> (-0.01%) ⬇️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.10% <ø> (+0.17%) ⬆️
agent 93.53% <ø> (ø)
api_server 91.94% <ø> (ø)
autoscaling 95.74% <ø> (ø)
catalog 92.36% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 91.82% <ø> (-0.56%) ⬇️
datcore_adapter 97.94% <ø> (ø)
director 75.90% <ø> (+0.08%) ⬆️
director_v2 90.87% <ø> (-0.03%) ⬇️
dynamic_scheduler 96.68% <ø> (-0.09%) ⬇️
dynamic_sidecar 90.43% <ø> (ø)
efs_guardian 89.62% <ø> (ø)
invitations 91.44% <ø> (ø)
payments 92.62% <ø> (ø)
resource_usage_tracker 92.29% <ø> (+0.10%) ⬆️
storage 86.65% <ø> (∅)
webclient ∅ <ø> (∅)
webserver 87.68% <ø> (+0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2eb46b7...1209bdd. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify
Copy link
Contributor

mergify bot commented Oct 1, 2025

🧪 CI Insights

Here's what we observed from your CI run for 1209bdd.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI system-tests Base branch is broken, but retries were needed. Could be early signs of flakiness 👀 Broken 1 View View

@bisgaard-itis bisgaard-itis enabled auto-merge (squash) October 1, 2025 12:51
@bisgaard-itis
Copy link
Contributor Author

@Mergifyio queue

@bisgaard-itis bisgaard-itis added the 🤖-automerge marks PR as ready to be merged for Mergify label Oct 1, 2025
@mergify
Copy link
Contributor

mergify bot commented Oct 1, 2025

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
      • any of: [🛡 GitHub branch protection]
        • check-success = SonarCloud Code Analysis
        • check-neutral = SonarCloud Code Analysis
        • check-skipped = SonarCloud Code Analysis

@bisgaard-itis bisgaard-itis merged commit 699808f into ITISFoundation:master Oct 1, 2025
145 of 148 checks passed
@bisgaard-itis bisgaard-itis deleted the 8439-increase-rpc-timeouts branch October 1, 2025 13:26
pcrespov added a commit to pcrespov/osparc-simcore that referenced this pull request Oct 1, 2025
pcrespov added a commit to pcrespov/osparc-simcore that referenced this pull request Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify Meta-modeling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Increase RPC timeout in function section of the api-server

3 participants