♻️ Refactor: migrate more aiohttp app keys to type-safe web.AppKey (follow up)
#8452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcrespov
added
a:webserver
pcrespov
changed the title
aiohttp app keys to type-safe web.AppKey (follow up)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8452 +/- ##
==========================================
+ Coverage 87.18% 87.21% +0.03%
==========================================
Files 1984 1483 -501
Lines 77284 62291 -14993
Branches 1333 678 -655
==========================================
- Hits 67377 54330 -13047
+ Misses 9508 7723 -1785
+ Partials 399 238 -161
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
pcrespov
requested review from
GitHK,
matusdrobuliak66 and
sanderegg
as code owners
pcrespov
force-pushed
the
is7734/more-app-keys
branch
from
2ba05b8 to
332b271
Compare
…ty and type safety
…KS_CONTEXT_APPKEY for consistency
…ONTEXT_REQKEY for consistency
pcrespov
force-pushed
the
is7734/more-app-keys
branch
from
332b271 to
ef92407
Compare
giancarloromeo
approved these changes
Oct 6, 2025
GitHK
approved these changes
Oct 6, 2025
services/web/server/src/simcore_service_webserver/long_running_tasks/plugin.py
Show resolved
Hide resolved
matusdrobuliak66
approved these changes
Oct 6, 2025
|
This was referenced Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Follows up refactoring webserver's
appstate keys from strings toweb.AppKey(see #7734)Application state key refactoring:
web.AppKeyobjects in the long-running tasks module, introducingAPP_LONG_RUNNING_MANAGER_APPKEYandRQT_LONG_RUNNING_TASKS_CONTEXT_APPKEYfor safer access to manager and task context objects (_manager.py,_request.py,_server.py,__init__.py, tests, and plugins). [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]CLIENT_SOCKET_REGISTRY_APPKEYfor registry access (_constants.py,plugin.py,registry.py). [1] [2] [3] [4] [5]PROJECT_PERMALINK_FACTORY_APPKEYinstead of a string key for the permalink factory coroutine (_permalink_service.py). [1] [2] [3]APP_CLIENT_SOCKET_DECORATED_HANDLERS_APPKEYandAPP_CLIENT_SOCKET_SERVER_APPKEYfor handler and server references, replacing string keys (_utils.py). [1] [2]Related issue/s
How to test
Dev-ops
None