Skip to content

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented Oct 3, 2025

What do these changes do?

Follows up from #8431 and fixes pact_broker tests

image
=========================== short test summary info ============================
ERROR tests/unit/pact_broker/test_pact_checkout_release.py::test_provider_against_pact - AttributeError: <module 'simcore_service_api_server.services_rpc.wb_api_server' from '/home/runner/work/osparc-simcore/osparc-simcore/.venv/lib/python3.11/site-packages/simcore_service_api_server/services_rpc/wb_api_server.py'> does not have the attribute '_checkout_licensed_item_for_wallet'
ERROR tests/unit/pact_broker/test_pact_licensed_items.py::test_provider_against_pact - AttributeError: <module 'simcore_service_api_server.services_rpc.wb_api_server' from '/home/runner/work/osparc-simcore/osparc-simcore/.venv/lib/python3.11/site-packages/simcore_service_api_server/services_rpc/wb_api_server.py'> does not have the attribute '_get_licensed_items'
============================== 2 errors in 2.65s ===============================
  • @matusdrobuliak66, I did not notice this in my PR, why not to add pact tests as required in the PR CIs?

Related issue/s

How to test

Dev-ops

None

@pcrespov pcrespov self-assigned this Oct 3, 2025
@pcrespov pcrespov added this to the Cheops milestone Oct 3, 2025
@pcrespov pcrespov marked this pull request as ready for review October 3, 2025 17:47
@pcrespov pcrespov requested review from GitHK, bisgaard-itis, giancarloromeo and wvangeit and removed request for GitHK October 3, 2025 17:47
@pcrespov pcrespov added t:maintenance Some planned maintenance work a:apiserver api-server service πŸ€–-automerge marks PR as ready to be merged for Mergify labels Oct 3, 2025
@pcrespov pcrespov enabled auto-merge (squash) October 3, 2025 17:51
@codecov
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 69.08%. Comparing base (dde3639) to head (f53e795).
⚠️ Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (dde3639) and HEAD (f53e795). Click for more details.

HEAD has 31 uploads less than BASE
Flag BASE (dde3639) HEAD (f53e795)
unittests 32 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #8455       +/-   ##
===========================================
- Coverage   87.72%   69.08%   -18.64%     
===========================================
  Files        1984      890     -1094     
  Lines       77284    39741    -37543     
  Branches     1333      175     -1158     
===========================================
- Hits        67797    27457    -40340     
- Misses       9088    12227     +3139     
+ Partials      399       57      -342     
Flag Coverage Ξ”
integrationtests 64.14% <ΓΈ> (+0.01%) ⬆️
unittests 91.78% <ΓΈ> (+5.37%) ⬆️
Components Coverage Ξ”
pkg_aws_library βˆ… <ΓΈ> (βˆ…)
pkg_celery_library βˆ… <ΓΈ> (βˆ…)
pkg_dask_task_models_library βˆ… <ΓΈ> (βˆ…)
pkg_models_library βˆ… <ΓΈ> (βˆ…)
pkg_notifications_library βˆ… <ΓΈ> (βˆ…)
pkg_postgres_database βˆ… <ΓΈ> (βˆ…)
pkg_service_integration βˆ… <ΓΈ> (βˆ…)
pkg_service_library βˆ… <ΓΈ> (βˆ…)
pkg_settings_library βˆ… <ΓΈ> (βˆ…)
pkg_simcore_sdk 76.81% <ΓΈ> (-8.15%) ⬇️
agent βˆ… <ΓΈ> (βˆ…)
api_server 91.78% <ΓΈ> (ΓΈ)
autoscaling βˆ… <ΓΈ> (βˆ…)
catalog βˆ… <ΓΈ> (βˆ…)
clusters_keeper βˆ… <ΓΈ> (βˆ…)
dask_sidecar βˆ… <ΓΈ> (βˆ…)
datcore_adapter βˆ… <ΓΈ> (βˆ…)
director βˆ… <ΓΈ> (βˆ…)
director_v2 78.04% <ΓΈ> (-12.94%) ⬇️
dynamic_scheduler βˆ… <ΓΈ> (βˆ…)
dynamic_sidecar 81.87% <ΓΈ> (-8.56%) ⬇️
efs_guardian βˆ… <ΓΈ> (βˆ…)
invitations βˆ… <ΓΈ> (βˆ…)
payments βˆ… <ΓΈ> (βˆ…)
resource_usage_tracker βˆ… <ΓΈ> (βˆ…)
storage βˆ… <ΓΈ> (βˆ…)
webclient βˆ… <ΓΈ> (βˆ…)
webserver 59.15% <ΓΈ> (-28.51%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update dde3639...f53e795. Read the comment docs.

πŸš€ New features to boost your workflow:
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify
Copy link
Contributor

mergify bot commented Oct 3, 2025

πŸ§ͺ CI Insights

Here's what we observed from your CI run for f53e795.

🟒 All jobs passed!

But CI Insights is watching πŸ‘€

@pcrespov
Copy link
Member Author

pcrespov commented Oct 3, 2025

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Oct 3, 2025

queue

🟠 Waiting for conditions to match

  • -closed [πŸ“Œ queue requirement]
  • any of: [πŸ”€ queue conditions]
    • all of: [πŸ“Œ queue conditions of queue default]
      • branch-protection-review-decision = APPROVED [πŸ›‘ GitHub branch protection]
      • #approved-reviews-by >= 2 [πŸ›‘ GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [πŸ›‘ GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [πŸ›‘ GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • label!=πŸ€–-do-not-merge
      • label=πŸ€–-automerge
      • any of: [πŸ›‘ GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [πŸ›‘ GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [πŸ›‘ GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [πŸ›‘ GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [πŸ›‘ GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [πŸ›‘ GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
      • any of: [πŸ›‘ GitHub branch protection]
        • check-success = SonarCloud Code Analysis
        • check-neutral = SonarCloud Code Analysis
        • check-skipped = SonarCloud Code Analysis
  • -conflict [πŸ“Œ queue requirement]
  • -draft [πŸ“Œ queue requirement]
  • any of: [πŸ“Œ queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2025

Copy link
Contributor

@wvangeit wvangeit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pcrespov pcrespov disabled auto-merge October 6, 2025 12:48
@pcrespov pcrespov merged commit 3d2e02a into ITISFoundation:master Oct 6, 2025
92 of 95 checks passed
@pcrespov pcrespov deleted the fix/pact-broker branch October 6, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

πŸ€–-automerge marks PR as ready to be merged for Mergify a:apiserver api-server service t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants