- 
                Notifications
    
You must be signed in to change notification settings  - Fork 32
 
π¨β [Maintenance] Add mock handler factory for LicensesRpcApi to fix pact tests #8455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
          Codecov Reportβ
 All modified and coverable lines are covered by tests. 
 Additional details and impacted files@@             Coverage Diff             @@
##           master    #8455       +/-   ##
===========================================
- Coverage   87.72%   69.08%   -18.64%     
===========================================
  Files        1984      890     -1094     
  Lines       77284    39741    -37543     
  Branches     1333      175     -1158     
===========================================
- Hits        67797    27457    -40340     
- Misses       9088    12227     +3139     
+ Partials      399       57      -342     
 
 Continue to review full report in Codecov by Sentry. 
 π New features to boost your workflow:
  | 
    
          
π§ͺ CI InsightsHere's what we observed from your CI run for f53e795. π’ All jobs passed!But CI Insights is watching π  | 
    
| 
           @mergify queue  | 
    
          
 π Waiting for conditions to match
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
2a81c26    to
    b373b12      
    Compare
  
    b373b12    to
    f53e795      
    Compare
  
    
          
 | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks



What do these changes do?
Follows up from #8431 and fixes
pact_brokertestsRelated issue/s
api-serverto avoid cross-service calls with the web-server variants (π¨)Β #8431How to test
Dev-ops
None