-
Notifications
You must be signed in to change notification settings - Fork 32
🐛 Fix listing function to avoid duplicates #8460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix listing function to avoid duplicates #8460
Conversation
|
Closes #8459 |
|
@mergify queue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
🟠 Waiting for conditions to match
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the quick fix
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8460 +/- ##
==========================================
- Coverage 87.69% 84.60% -3.09%
==========================================
Files 1983 767 -1216
Lines 77277 35184 -42093
Branches 1333 175 -1158
==========================================
- Hits 67771 29769 -38002
+ Misses 9107 5358 -3749
+ Partials 399 57 -342
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
🧪 CI InsightsHere's what we observed from your CI run for 9d7cfb0. 🟢 All jobs passed!But CI Insights is watching 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…arc-simcore into fix_list_functions_too_many
…arc-simcore into fix_list_functions_too_many
|



What do these changes do?
There is a bug in list_functions that makes it list some functions sometimes more than once.
This is caused by a join with the function permissions. If a user receives read permissions for a function from several groups, it gets returned multiple times.
Related issue/s
#8459
How to test
I've added a test.
List the functions of a user that has at least one function it gets permission from through several groups.
Dev-ops
No changes