Skip to content

Conversation

@wvangeit
Copy link
Contributor

@wvangeit wvangeit commented Oct 6, 2025

What do these changes do?

There is a bug in list_functions that makes it list some functions sometimes more than once.
This is caused by a join with the function permissions. If a user receives read permissions for a function from several groups, it gets returned multiple times.

Related issue/s

#8459

How to test

I've added a test.
List the functions of a user that has at least one function it gets permission from through several groups.

Dev-ops

No changes

@wvangeit wvangeit requested a review from bisgaard-itis October 6, 2025 12:45
@wvangeit wvangeit self-assigned this Oct 6, 2025
@wvangeit wvangeit requested a review from pcrespov as a code owner October 6, 2025 12:45
@wvangeit wvangeit added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Oct 6, 2025
@wvangeit wvangeit added the 🤖-automerge marks PR as ready to be merged for Mergify label Oct 6, 2025
@wvangeit wvangeit requested a review from alexpargon October 6, 2025 12:48
@wvangeit wvangeit added this to the Cheops milestone Oct 6, 2025
@pcrespov pcrespov changed the title Fix listing function to avoid duplicates 🐛 🐛 Fix listing function to avoid duplicates Oct 6, 2025
@wvangeit
Copy link
Contributor Author

wvangeit commented Oct 6, 2025

Closes #8459

@wvangeit
Copy link
Contributor Author

wvangeit commented Oct 6, 2025

@mergify queue

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@mergify
Copy link
Contributor

mergify bot commented Oct 6, 2025

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
      • any of: [🛡 GitHub branch protection]
        • check-success = SonarCloud Code Analysis
        • check-neutral = SonarCloud Code Analysis
        • check-skipped = SonarCloud Code Analysis

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick fix

@codecov
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.60%. Comparing base (266c7c3) to head (9d7cfb0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8460      +/-   ##
==========================================
- Coverage   87.69%   84.60%   -3.09%     
==========================================
  Files        1983      767    -1216     
  Lines       77277    35184   -42093     
  Branches     1333      175    -1158     
==========================================
- Hits        67771    29769   -38002     
+ Misses       9107     5358    -3749     
+ Partials      399       57     -342     
Flag Coverage Δ
integrationtests 64.14% <ø> (+0.03%) ⬆️
unittests 86.90% <ø> (+0.50%) ⬆️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 76.81% <ø> (-8.15%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.22% <ø> (-12.69%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 81.87% <ø> (-8.56%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 87.65% <ø> (+0.03%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 266c7c3...9d7cfb0. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify
Copy link
Contributor

mergify bot commented Oct 6, 2025

🧪 CI Insights

Here's what we observed from your CI run for 9d7cfb0.

🟢 All jobs passed!

But CI Insights is watching 👀

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wvangeit wvangeit enabled auto-merge (squash) October 6, 2025 17:10
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2025

@wvangeit wvangeit merged commit 9d5b558 into ITISFoundation:master Oct 6, 2025
92 of 95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants