-
Notifications
You must be signed in to change notification settings - Fork 32
🐛 Fix: enforce consistent WEBSERVER_RPC_NAMESPACE in docker-compose to prevent deploy bug
#8463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix: enforce consistent WEBSERVER_RPC_NAMESPACE in docker-compose to prevent deploy bug
#8463
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8463 +/- ##
==========================================
- Coverage 87.72% 87.70% -0.03%
==========================================
Files 1983 1983
Lines 77277 77277
Branches 1333 1333
==========================================
- Hits 67790 67773 -17
- Misses 9088 9105 +17
Partials 399 399
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a temporary fix to prevent deployment bugs by enforcing consistent WEBSERVER_RPC_NAMESPACE configuration across services. The change ensures that webserver, wb-db-event-listener, and wb-garbage-collector services all use the hardcoded value "webserver" instead of the variable ${WEBSERVER_HOST}, maintaining consistency with payments and director-v2 services.
Key Changes:
- Hardcoded
WEBSERVER_RPC_NAMESPACEto "webserver" in docker-compose configuration for three services - Added comprehensive tests to validate RPC namespace configuration requirements across different service types
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| services/docker-compose.yml | Updated WEBSERVER_RPC_NAMESPACE from variable to hardcoded "webserver" for consistency |
| services/web/server/tests/unit/isolated/test_application_settings.py | Added test suite to validate RPC namespace requirements across service types |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
services/web/server/tests/unit/isolated/test_application_settings.py
Outdated
Show resolved
Hide resolved
services/web/server/tests/unit/isolated/test_application_settings.py
Outdated
Show resolved
Hide resolved
services/web/server/tests/unit/isolated/test_application_settings.py
Outdated
Show resolved
Hide resolved
services/web/server/tests/unit/isolated/test_application_settings.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok 👍 🐰 thx
🧪 CI InsightsHere's what we observed from your CI run for 41602e1. 🟢 All jobs passed!But CI Insights is watching 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
1b7e1cf to
41602e1
Compare
|



What do these changes do?
This PR introduces a temporary patch to prevent a deployment bug, until #8448 is resolved.
It enforces, in the
docker-composeconfiguration, that thewebserverservice usesWEBSERVER_RPC_NAMESPACE = DEFAULT_WEBSERVER_RPC_NAMESPACE = webserver, ensuring consistency with thepaymentsanddirector-v2services, which communicate usingDEFAULT_WEBSERVER_RPC_NAMESPACE.Additionally, this PR includes tests to validate this condition until #8448 is resolved.
Related issue/s
api-serverto avoid cross-service calls with the web-server variants (🚨) #8431webserverRPC client and use new everywhere #8448How to test
Dev-ops
None