- 
                Notifications
    
You must be signed in to change notification settings  - Fork 32
 
🐛 Agent should be able to read files in directory now #8466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Agent should be able to read files in directory now #8466
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug where rclone cannot access certain directories during volume backup by granting full permissions to all users on the source directory.
- Updates the 
_ensure_permissions_on_source_dirfunction to use broader permission settings - Changes from granting only read/execute permissions to others to full 777 permissions for all users
 - Adds ownership change to root:root before setting permissions
 
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
          Codecov Report✅ All modified and coverable lines are covered by tests. 
 Additional details and impacted files@@             Coverage Diff             @@
##           master    #8466       +/-   ##
===========================================
- Coverage   87.63%   66.55%   -21.09%     
===========================================
  Files        1983      788     -1195     
  Lines       77284    35764    -41520     
  Branches     1333      175     -1158     
===========================================
- Hits        67727    23801    -43926     
- Misses       9158    11906     +2748     
+ Partials      399       57      -342     
 
 Continue to review full report in Codecov by Sentry. 
 🚀 New features to boost your workflow:
  | 
    
          
 | 
    



What do these changes do?
During volume backup, rclone cannot access certain directories and folders. Full permissions have been granted to all users to avoid any file access issues. Since these directories will be removed, it is OK to do so.
NOTE: this comes form production and all UUIDs have been recrated and repalced
Related issue/s
How to test
Dev-ops